Uh oh!
There was an error while loading. Please reload this page.
Use SCSS for jquery-ui-fixes - #6341
Conversation
- Move to SCSS so we use theming color values - Apply tab style from files sidebar to ui-tabs (e.g. in user_ldap) - Move select style to the jquery-ui-fixes file and make those only apply to ui-autocomplete elements Signed-off-by: Julius Härtl <jus@bitgrid.net>
mention-bot
commented
Sep 2, 2017
@juliushaertl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @skjnldsv, @jancborchardt and @DeepDiver1975 to be potential reviewers. |
| @@ -8,29 +8,29 @@ | |||
| font-family: "Lucida Grande", Arial, Verdana, sans-serif; | |||
There was a problem hiding this comment.
Drop it, because it is overwritten and outdated anyways. (same with the statement above)
| @import 'multiselect.scss'; | ||
| @import 'mobile.scss'; | ||
| @import 'tooltip.scss'; | ||
| @import 'tooltip.scss'; No newline at end of file |
7b06dff to
145f421CompareCodecov Report
@@ Coverage Diff @@## master #6341 +/- ##
===========================================
- Coverage 53.31% 53.3% -0.01%
Complexity 22497 22497 ===========================================
Files 1403 1403 Lines 87079 87079 Branches 1327 1327 ===========================================
- Hits 46422 46421 -1 - Misses 40657 40658 +1
|
Signed-off-by: Julius Härtl <jus@bitgrid.net>
145f421 to
99404feCompare| .ui-state-active { | ||
| border: none; | ||
| border-bottom: 1px solid $color-main-text; | ||
| color: $color-primary-text; |
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
commented
Sep 3, 2017
I fixed the font colouring: @juliushaertl Please have a look if this is okay with you. Thanks |
@MorrisJobke Makes sense 👍 Thanks for fixing. |
pixelipo
commented
Sep 4, 2017
Nice work, @juliushaertl We should also move this stuff over to core/css/jquery-ui-fixes.scss : Lines 990 to 1072 in ad5a298 |
jancborchardt
commented
Sep 7, 2017
Good stuff @juliushaertl! Thanks a lot :) |


This PR contains several improvements for our jquery-ui-fixes:
Fixes#1090#5348#6178