Skip to content

Fix "searchUsers" usage in Group_LDAP.php - #25318

Merged
ChristophWurst merged 1 commit into
nextcloud:masterfrom
hho:patch-1
Mar 30, 2021
Merged

Fix "searchUsers" usage in Group_LDAP.php#25318
ChristophWurst merged 1 commit into
nextcloud:masterfrom
hho:patch-1

Conversation

@hho

@hhohho commented Jan 25, 2021

Copy link
Copy Markdown
Contributor

Access::searchUsers expects an array as the second parameter, Group_LDAP.php called the method with a simple string, resulting in an exception and preventing folders shared with dynamic groups from working. This trivial change fixes the usage in Group_LDAP.

Fixes#25163

@hho
Fix "searchUsers" usage in Group_LDAP.php
dfd07cc
`Access::searchUsers` expects an array as the second parameter, `Group_LDAP.php` called the method with a simple string, resulting in an exception and preventing folders shared with dynamic groups from working. This trivial change fixes the usage in Group_LDAP.
Fixes#25163
Signed-off-by: Henning Hoefer <hho@users.noreply.github.com>
@PVince81
PVince81 requested a review from blizzzMarch 17, 2021 09:24
@blizzzblizzz added this to the Nextcloud 22 milestone Mar 17, 2021
@blizzz

blizzz commented Mar 17, 2021

Copy link
Copy Markdown
Member

/backport to stable21

@blizzz

blizzz commented Mar 17, 2021

Copy link
Copy Markdown
Member

/backport to stable20

@blizzz

blizzz commented Mar 17, 2021

Copy link
Copy Markdown
Member

/backport to stable19

@blizzz

blizzz commented Mar 17, 2021

Copy link
Copy Markdown
Member

@hho thank you for the fix! :)

@ChristophWurst
ChristophWurst merged commit c9e1821 into nextcloud:masterMar 30, 2021
@welcome

welcomeBot commented Mar 30, 2021

Copy link
Copy Markdown

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@backportbot-nextcloud

backportbot-nextcloudBot commented Mar 30, 2021

Copy link
Copy Markdown

The backport to stable21 failed. Please do this backport manually.

@backportbot-nextcloud

backportbot-nextcloudBot commented Mar 30, 2021

Copy link
Copy Markdown

The backport to stable20 failed. Please do this backport manually.

@backportbot-nextcloud

backportbot-nextcloudBot commented Mar 30, 2021

Copy link
Copy Markdown

The backport to stable19 failed. Please do this backport manually.

@rullzer

rullzer commented Mar 30, 2021

Copy link
Copy Markdown
Member

@blizzz backports failed :(

@blizzz

blizzz commented Mar 30, 2021

Copy link
Copy Markdown
Member

@blizzz backports failed :(

Interestingly the fix was already there (21 and below) from #25361 and its backports. No idea why this master was lacking the change, the blame before for this line goes back 12 months in the past.

@blizzz

blizzz commented Mar 30, 2021

Copy link
Copy Markdown
Member

Probably just overwriting the change from the mentioned PR which was merged only few days after this PR here was opened.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurstChristophWurstChristophWurst approved these changes
@blizzzblizzzblizzz approved these changes
@skjnldsvskjnldsvAwaiting requested review from skjnldsv

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbugfeature: ldap

Projects

None yet

Milestone

Nextcloud 22

Development

Successfully merging this pull request may close these issues.

Can't delete a shared folder if the users are members of a dynamic LDAP Group

4 participants

@hho@blizzz@rullzer@ChristophWurst