Uh oh!
There was an error while loading. Please reload this page.
fix parameter provided as string not array - #25361
Merged
Merged
Conversation
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
commented
Jan 28, 2021
MemberAuthor
/backport to stable20 |
blizzz
commented
Jan 28, 2021
MemberAuthor
/backport to stable19 |
nickvergessen
approved these changes
Jan 28, 2021
nickvergessen
left a comment
Member
There was a problem hiding this comment.
🙈, is there no Psalm available for the ldap methods? cough
blizzz
commented
Jan 28, 2021
MemberAuthor
you're asking things. tbh, i did not look into Psalm much yet. Nevertheless I was having a false positive of it in LDAP code. In the Psalm config apps/ is included and there is no special treatment for anything LDAP related. |
rullzer
approved these changes
Jan 28, 2021
This was referenced Jan 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
array is enforced through TypeHint