Uh oh!
There was an error while loading. Please reload this page.
Only clear share password model when actually saved - #25911
Merged
Conversation
PVince81
requested review from
ChristophWurst, danxuliu, juliusknorr, nickvergessen and rullzerMarch 3, 2021 10:34
PVince81
commented
Mar 3, 2021
MemberAuthor
/backport to stable21 |
PVince81
commented
Mar 3, 2021
MemberAuthor
/backport to stable20 |
PVince81
commented
Mar 3, 2021
MemberAuthor
/backport to stable19 |
PVince81
commented
Mar 3, 2021
MemberAuthor
pfff, so compiling with |
PVince81
commented
Mar 3, 2021
MemberAuthor
/compile amend / |
npmbuildbot-nextcloudBotforce-pushed
the
bugfix/noid/fix-share-password-saving
branch
from
March 3, 2021 10:55
7bbe482 to
3b8a7d6Comparerullzer
approved these changes
Mar 3, 2021
PVince81
commented
Mar 4, 2021
MemberAuthor
/compile amend / |
1 similar comment
PVince81
commented
Mar 8, 2021
MemberAuthor
/compile amend / |
PVince81
commented
Mar 11, 2021
MemberAuthor
pfff, why isn't the amend working ? |
PVince81
commented
Mar 11, 2021
MemberAuthor
let me do this manually... |
Instead of always clearing the password in the share model, now only do it when it was actually saved. Fixes an issue where saving another field would clear the password too early and prevent it to be saved when the dropdown closed. Signed-off-by: Vincent Petry <vincent@nextcloud.com> Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
PVince81force-pushed
the
bugfix/noid/fix-share-password-saving
branch
from
March 11, 2021 08:07
3b8a7d6 to
3462444CompareChristophWurst
approved these changes
Mar 11, 2021
This was referenced Mar 11, 2021
skjnldsv
commented
Mar 11, 2021
Member
you're not alone, let me check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of always clearing the password in the share model, now only do
it when it was actually saved.
Fixes an issue where saving another field would clear the password too
early and prevent it to be saved when the dropdown closed.