Uh oh!
There was an error while loading. Please reload this page.
Catch invalid cache source storage path - #26270
Merged
Merged
Conversation
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
requested review from
MorrisJobke, blizzz, icewind1991, nickvergessen and rullzerMarch 24, 2021 09:38
skjnldsv
commented
Mar 24, 2021
MemberAuthor
/backport to stable21 |
skjnldsv
commented
Mar 24, 2021
MemberAuthor
/backport to stable20 |
skjnldsv
commented
Mar 24, 2021
MemberAuthor
/backport to stable19 |
MorrisJobke
commented
Mar 24, 2021
Member
😭 |
MorrisJobke
commented
Mar 24, 2021
Member
Shouldn't psalm catch this? |
MorrisJobke
approved these changes
Mar 24, 2021
MorrisJobke
left a comment
Member
There was a problem hiding this comment.
I still wonder why Psalm didn't found this one as the PHPDoc is correct for them. 🤔
blizzz
approved these changes
Mar 24, 2021
This was referenced Mar 24, 2021
joshtrichards added a commit
to joshtrichards/nc-server
that referenced
this pull request
Aug 3, 2023
OC\Files\Cache\Cache::get can return string|false|null, not just string|false. - nextcloud#26270 added handling of false, but null is needed too. - Well, or we change the default $resullt to false, but I'm not sure if that has other ramifications and the real need here is to simply catch situations where the cache source storage path is not valid for whatever reason Related: nextcloud#19009 Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
5 tasks
backportbot-nextcloudBot
pushed a commit
that referenced
this pull request
Aug 5, 2023
OC\Files\Cache\Cache::get can return string|false|null, not just string|false. - #26270 added handling of false, but null is needed too. - Well, or we change the default $resullt to false, but I'm not sure if that has other ramifications and the real need here is to simply catch situations where the cache source storage path is not valid for whatever reason Related: #19009 Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
backportbot-nextcloudBot
pushed a commit
that referenced
this pull request
Aug 5, 2023
OC\Files\Cache\Cache::get can return string|false|null, not just string|false. - #26270 added handling of false, but null is needed too. - Well, or we change the default $resullt to false, but I'm not sure if that has other ramifications and the real need here is to simply catch situations where the cache source storage path is not valid for whatever reason Related: #19009 Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
backportbot-nextcloudBot
pushed a commit
that referenced
this pull request
Aug 6, 2023
OC\Files\Cache\Cache::get can return string|false|null, not just string|false. - #26270 added handling of false, but null is needed too. - Well, or we change the default $resullt to false, but I'm not sure if that has other ramifications and the real need here is to simply catch situations where the cache source storage path is not valid for whatever reason Related: #19009 Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
kesselb pushed a commit
that referenced
this pull request
Dec 1, 2023
OC\Files\Cache\Cache::get can return string|false|null, not just string|false. - #26270 added handling of false, but null is needed too. - Well, or we change the default $resullt to false, but I'm not sure if that has other ramifications and the real need here is to simply catch situations where the cache source storage path is not valid for whatever reason Related: #19009 Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OC\Files\Cache\Cache::getcan also return false