Uh oh!
There was an error while loading. Please reload this page.
Catch more invalid cache source storage paths - #39698
Merged
skjnldsv merged 2 commits intoAug 5, 2023
Merged
Conversation
OC\Files\Cache\Cache::get can return string|false|null, not just string|false. - nextcloud#26270 added handling of false, but null is needed too. - Well, or we change the default $resullt to false, but I'm not sure if that has other ramifications and the real need here is to simply catch situations where the cache source storage path is not valid for whatever reason Related: nextcloud#19009 Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
solracsf
reviewed
Aug 4, 2023
Uh oh!
There was an error while loading. Please reload this page.
solracsf
approved these changes
Aug 4, 2023
solracsf
left a comment
Member
There was a problem hiding this comment.
Appart my comment above, makes sense.
solracsf
commented
Aug 4, 2023
Member
/backport to stable27 |
solracsf
commented
Aug 4, 2023
Member
/backport to stable26 |
solracsf
commented
Aug 4, 2023
Member
/backport to stable25 |
skjnldsv
approved these changes
Aug 4, 2023
Co-authored-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
solracsf
commented
Aug 5, 2023
Member
/backport to stable26 |
solracsf
commented
Aug 6, 2023
Member
/backport to stable25 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OC\Files\Cache\Cache::getcan return string|false|null, not just string|false.Since null is just as much of an indicator that something is wrong with the specified cache source storage path, handle it same way as false.
TODO
Checklist