Skip to content

Fix "never catch" catches in OC_App - #28138

Merged
skjnldsv merged 1 commit into
masterfrom
zorn-v-patch-2
Oct 23, 2021
Merged

Fix "never catch" catches in OC_App#28138
skjnldsv merged 1 commit into
masterfrom
zorn-v-patch-2

Conversation

@zorn-v

Copy link
Copy Markdown
Member

Need to check another legacy. Need to explicitly add to use or do not forget add slash \

@szaimen

Copy link
Copy Markdown
Contributor

Is this ready for review?

@szaimenszaimen added the 2. developing Work in progress label Aug 31, 2021
@szaimenszaimen added this to the Nextcloud 23 milestone Aug 31, 2021
@skjnldsvskjnldsv mentioned this pull request Oct 13, 2021
@skjnldsv
skjnldsv requested review from a team, PVince81, nickvergessen and skjnldsv and removed request for a teamOctober 21, 2021 15:39
@skjnldsvskjnldsv added 3. to review Waiting for reviews bug and removed 2. developing Work in progress labels Oct 21, 2021

@PVince81PVince81 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@skjnldsv

Copy link
Copy Markdown
Member

/rebase

@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 22, 2021
Need to check another legacy. Need to explicitly add to use or do not forget add slash `\`
@skjnldsv
skjnldsv merged commit c5e9f37 into masterOct 23, 2021
@skjnldsv
skjnldsv deleted the zorn-v-patch-2 branch October 23, 2021 09:18
@nickvergessen

Copy link
Copy Markdown
Member

For me this now yields a warning on all maschines?

PHP Warning: The use statement with non-compound name 'Throwable' has no effect in /var/www/html/lib/private/legacy/OC_App.php on line 66

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@zorn-v@szaimen@skjnldsv@nickvergessen@PVince81