Skip to content

Revert "Fix "never catch" catches in OC_App" - #29425

Merged
skjnldsv merged 1 commit into
masterfrom
revert-28138-zorn-v-patch-2
Oct 25, 2021
Merged

Revert "Fix "never catch" catches in OC_App"#29425
skjnldsv merged 1 commit into
masterfrom
revert-28138-zorn-v-patch-2

Conversation

@nickvergessen

@nickvergessennickvergessen commented Oct 25, 2021

Copy link
Copy Markdown
Member

Reverts #28138 to get rid of the warning spam:

The use statement with non-compound name 'Throwable' has no effect

OC_App file has no namespace so importing a non-namespaced thing yields the warning.

@nickvergessennickvergessen added the 3. to review Waiting for reviews label Oct 25, 2021
@nickvergessennickvergessen added this to the Nextcloud 23 milestone Oct 25, 2021
PVince81
PVince81 approved these changes Oct 25, 2021
View reviewed changes

@PVince81PVince81 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@skjnldsv
skjnldsv merged commit d231d26 into masterOct 25, 2021
@skjnldsv
skjnldsv deleted the revert-28138-zorn-v-patch-2 branch October 25, 2021 07:25
@skjnldsvskjnldsv mentioned this pull request Oct 25, 2021
Merged
25 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81PVince81PVince81 approved these changes
@kesselbkesselbkesselb approved these changes
@zorn-vzorn-vAwaiting requested review from zorn-v
@skjnldsvskjnldsvAwaiting requested review from skjnldsv

Assignees

No one assigned

Labels

3. to reviewWaiting for reviews

Projects

None yet

Milestone

Nextcloud 23

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen@PVince81@kesselb@skjnldsv