Skip to content

Fix file creation from template without ext - #28871

Merged
Pytal merged 1 commit into
masterfrom
fix/template-create-without-extension
Sep 17, 2021
Merged

Fix file creation from template without ext#28871
Pytal merged 1 commit into
masterfrom
fix/template-create-without-extension

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Sep 17, 2021

Copy link
Copy Markdown
Member

Reproducing:

  1. Create a new text file
  2. Enter a name without the .md extension
  3. Select any template
  4. See error

@skjnldsv
Fix file creation from template without ext
ed8aacf
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
skjnldsv requested a review from a teamSeptember 17, 2021 08:09
@skjnldsvskjnldsv self-assigned this Sep 17, 2021
@skjnldsv
skjnldsv requested review from Pytal, artonge and julien-nc and removed request for a teamSeptember 17, 2021 08:09
@skjnldsvskjnldsv added this to the Nextcloud 23 milestone Sep 17, 2021
@skjnldsv

skjnldsv commented Sep 17, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to stable22

@skjnldsv

skjnldsv commented Sep 17, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to stable21

@skjnldsv
skjnldsv requested a review from a teamSeptember 17, 2021 08:10
PVince81
PVince81 approved these changes Sep 17, 2021
View reviewed changes

@PVince81PVince81 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine 👍

@skjnldsvskjnldsv mentioned this pull request Sep 17, 2021
Closed
@skjnldsvskjnldsv linked an issue Sep 17, 2021 that may be closed by this pull request
Alert “Unable to create new file from template” #26672
Closed
@skjnldsvskjnldsv removed a link to an issue Sep 17, 2021
Alert “Unable to create new file from template” #26672
Closed
@Pytal

Pytal commented Sep 17, 2021

Copy link
Copy Markdown
Member

⚙failures unrelated

@Pytal
Pytal merged commit a102333 into masterSep 17, 2021
@Pytal
Pytal deleted the fix/template-create-without-extension branch September 17, 2021 20:19
@PytalPytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 17, 2021
@szaimen

szaimen commented Sep 17, 2021

Copy link
Copy Markdown
Contributor

/backport to stable20

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Sep 17, 2021
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Sep 17, 2021

Copy link
Copy Markdown

The backport to stable20 failed. Please do this backport manually.

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Sep 17, 2021
Merged
@szaimen

szaimen commented Sep 17, 2021

Copy link
Copy Markdown
Contributor

Were templates introduced with NC21?

@PVince81

PVince81 commented Sep 20, 2021

Copy link
Copy Markdown
Member

Were templates introduced with NC21?

indeed, let's skip the NC 20 backport then

@szaimenszaimen mentioned this pull request Sep 29, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81PVince81PVince81 approved these changes
@PytalPytalPytal approved these changes
@artongeartongeAwaiting requested review from artonge
@julien-ncjulien-ncAwaiting requested review from julien-nc

Assignees

@skjnldsvskjnldsv

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: templates

Projects

None yet

Milestone

Nextcloud 23

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv@Pytal@szaimen@PVince81