Uh oh!
There was an error while loading. Please reload this page.
[stable22] Fix file creation from template without ext - #28881
Merged
Conversation
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
backportbot-nextcloudBot
requested review from
PVince81, Pytal, artonge, julien-nc and skjnldsvSeptember 17, 2021 20:23
PVince81
commented
Sep 20, 2021
Member
@artonge thanks for fixing the partial backport. When you do, please make sure to remove or strike out the conflict notice in the original post. I've done that for you now 🙂 |
PVince81
commented
Sep 20, 2021
Member
looks like you forgot recompiling. I just tested and it was broken. I'll recompile and retest |
PVince81
commented
Sep 20, 2021
Member
/compile amend / |
Signed-off-by: Louis Chemineau <louis@chmn.me> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-commandforce-pushed
the
backport/28871/stable22
branch
from
September 20, 2021 09:09
f49e023 to
c128e0aComparePVince81
commented
Sep 20, 2021
Member
strangely from this PR I can't create a text file from template, not even with an extension but it works on stable22 with an extension maybe issue with the conflict resolution ? |
artonge
commented
Sep 21, 2021
Collaborator
/compile amend / |
Signed-off-by: Louis Chemineau <louis@chmn.me> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-commandforce-pushed
the
backport/28871/stable22
branch
from
September 21, 2021 10:42
2f30ca0 to
0e77b0fCompareartonge
approved these changes
Sep 21, 2021
Collaborator
MichaIng
approved these changes
Sep 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #28871