Skip to content

Revert "Merge pull request #28817 from nextcloud/dependabot/npm_and_yarn/bootstrap-5.1.1" - #29105

Merged
artonge merged 2 commits into
masterfrom
revert/28817
Oct 11, 2021
Merged

Revert "Merge pull request #28817 from nextcloud/dependabot/npm_and_yarn/bootstrap-5.1.1"#29105
artonge merged 2 commits into
masterfrom
revert/28817

Conversation

@Pytal

@PytalPytal commented Oct 7, 2021

Copy link
Copy Markdown
Member

Revert #28817
Fix#29104

@PytalPytal added bug 3. to review Waiting for reviews labels Oct 7, 2021
@Pytal
Pytal requested review from a team, MichaIng and artongeOctober 7, 2021 03:26
@PytalPytal self-assigned this Oct 7, 2021
@Pytal
Pytal requested review from PVince81 and skjnldsv and removed request for a teamOctober 7, 2021 03:26
@PytalPytal mentioned this pull request Oct 7, 2021
Merged
MichaIng
MichaIng reviewed Oct 7, 2021
View reviewed changes
Comment threadapps/files/js/newfilemenu.js Outdated
@MichaIng

MichaIng commented Oct 7, 2021

Copy link
Copy Markdown
Member

Makes sense. Probably nextcloud-vue tooltips are the issue/broken by this. Also there is the other issue of the broken Bootstrap tooltips polyfill (for translating removed arguments), which should be resolved first (it still required for apps), see: #28817 (comment)

@Pytal
Pytal requested a review from MichaIngOctober 7, 2021 15:59
@Pytal@artonge
Revert "Merge pull request#28817from nextcloud/dependabot/npm_and_y…
006fdcc
…arn/bootstrap-5.1.1"
This reverts commit 6b2711f, reversing
changes made to d0a1d99.
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal@artonge
Set tooltip container correctly
3b79924
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@artonge
artonge merged commit 3390b48 into masterOct 11, 2021
@artonge
artonge deleted the revert/28817 branch October 11, 2021 13:16
@artongeartonge mentioned this pull request Oct 11, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artongeartongeartonge approved these changes
@MichaIngMichaIngMichaIng approved these changes
@PVince81PVince81Awaiting requested review from PVince81
@skjnldsvskjnldsvAwaiting requested review from skjnldsv

Assignees

@PytalPytal

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tooltips rendering incorrectly

3 participants

@Pytal@MichaIng@artonge