Skip to content

Bump bootstrap from 4.6.0 to 5.1.3 - #29154

Closed
dependabot[bot] wants to merge 1 commit into
masterfrom
dependabot/npm_and_yarn/bootstrap-5.1.3
Closed

Bump bootstrap from 4.6.0 to 5.1.3#29154
dependabot[bot] wants to merge 1 commit into
masterfrom
dependabot/npm_and_yarn/bootstrap-5.1.3

Conversation

@dependabot

@dependabotdependabotBot commented on behalf of githubOct 10, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Bumps bootstrap from 5.1.1 to 5.1.3.

Release notes

Sourced from bootstrap's releases.

v5.1.3

Fixes

🎨 CSS

  • #35143: Revert "Add align-self: center to buttons for improved rendering in flex containers"

v5.1.2

Highlights

  • Temporarily patched a postcss-values-parser issue by rearranging our calc() functions that use negative numbers. This should restore the ability to import and compile Bootstrap's Sass in create-react-app.
  • Added border-radius sizes to small and large .form-selects
  • Added align-self: center to buttons for improved rendering in flex containers
  • Fixed Collapse regression that prevented toggling between sibling children
  • Updated JS Sanitizer to add sms in the SAFE_URL_PATTERN
  • Improved docs around .img-fluid
  • Added role="switch" to our form switches in our docs
  • Implemented GitHub Issue forms to replace our previous issue templates.

Changes

🎨 CSS

  • #34799: fix custom property values of row overrides individual cell
  • #34834: Add align-self: center to buttons for improved rendering in flex containers
  • #34853: Add border-radius sizes to small and large .form-selects
  • #34861: Separator for table direct children
  • #35017: Use Sass variable instead of RGB components
  • #35033: Add workaround for dart sass compile error

☕️ JavaScript

  • #34951: Fix Collapse regression of handling toggling between sibling chilldren
  • #34980: Minor refactoring
  • #35074: sanitizer: add sms in the SAFE_URL_PATTERN

📖 Docs

  • #34824: docs: Add role="switch" to switches
  • #34918: docs: Update RFS version & move "v" prefix to config.yml
  • #34920: Fix Backdroped typo
  • #34921: Fix JavaScript typo
  • #34922: fix predefined typo
  • #34923: fix utilities typo
  • #34926: Improve description of .img-fluid in docs
  • #34935: Non-blocking typo fix
  • #34936: replace dummy text with English for Text truncation page
  • #34946: Changes some latin/dummy text to English
  • #35013: Add offcanvas to the components requiring JavaScript
  • #35111: Fix capitalization after period in contents.md

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @nextcloud-command.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
dependabotBot requested a review from a teamOctober 10, 2021 17:28
@dependabotdependabotBot mentioned this pull request Oct 10, 2021
Closed
nextcloud-command
nextcloud-command approved these changes Oct 10, 2021
View reviewed changes

@nextcloud-commandnextcloud-command left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

@dependabot@github

dependabotBot commented on behalf of githubOct 10, 2021

Copy link
Copy Markdown
ContributorAuthor

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

MichaIng
MichaIng requested changes Oct 10, 2021
View reviewed changes

@MichaIngMichaIng left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking as of: #29105

@MichaIngMichaIng added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Oct 10, 2021
@artonge

artonge commented Oct 11, 2021•
edited
Loading

Copy link
Copy Markdown
Collaborator

Blocking as of: #29105

#29105 is now merged, unblocking.

@dependabot
dependabotBotforce-pushed the dependabot/npm_and_yarn/bootstrap-5.1.3 branch 2 times, most recently from 517bd1e to c33941dCompareOctober 11, 2021 13:23
nextcloud-command
nextcloud-command approved these changes Oct 11, 2021
View reviewed changes

@nextcloud-commandnextcloud-command left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

nextcloud-command
nextcloud-command approved these changes Oct 11, 2021
View reviewed changes

@nextcloud-commandnextcloud-command left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

@MichaIngMichaIng changed the title Bump bootstrap from 5.1.1 to 5.1.3Bump bootstrap from 4.6.0 to 5.1.3Oct 11, 2021
@MichaIng

MichaIng commented Oct 11, 2021

Copy link
Copy Markdown
Member

unblocking

The issues with the polyfill and the broken nextcloud-vue tooltips still need to be solved. Linking the related discussion and investigation we started about this: https://github.com/nextcloud/server/pull/28817/files

@MichaIngMichaIng added this to the Nextcloud 24 milestone Oct 30, 2021
@dependabot
dependabotBotforce-pushed the dependabot/npm_and_yarn/bootstrap-5.1.3 branch from c33941d to ff4b5c9CompareNovember 20, 2021 05:45
@dependabot
Bump bootstrap from 5.1.1 to 5.1.3
c309dfb
Bumps [bootstrap](https://github.com/twbs/bootstrap) from 5.1.1 to 5.1.3.
- [Release notes](https://github.com/twbs/bootstrap/releases)
- [Commits](twbs/bootstrap@v5.1.1...v5.1.3)
---
updated-dependencies:
- dependency-name: bootstrap
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabotBotforce-pushed the dependabot/npm_and_yarn/bootstrap-5.1.3 branch from ff4b5c9 to c309dfbCompareJanuary 8, 2022 07:19
@skjnldsvskjnldsv closed this Jan 8, 2022
@dependabot@github

dependabotBot commented on behalf of githubJan 8, 2022

Copy link
Copy Markdown
ContributorAuthor

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot
dependabotBot deleted the dependabot/npm_and_yarn/bootstrap-5.1.3 branch January 8, 2022 09:17
@MichaIngMichaIng removed this from the Nextcloud 24 milestone Jan 8, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaIngMichaIngMichaIng requested changes
@github-actionsgithub-actions[bot]github-actions[bot] approved these changes
@nextcloud-commandnextcloud-commandnextcloud-command approved these changes

Assignees

No one assigned

Labels

2. developingWork in progressfeature: dependencies

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@artonge@MichaIng@nextcloud-command@skjnldsv