Skip to content

Always store and compare the email address as lower case - #30197

Merged
Pytal merged 5 commits into
masterfrom
bugfix/noid/always-store-email-lowercase
Dec 14, 2021
Merged

Always store and compare the email address as lower case#30197
Pytal merged 5 commits into
masterfrom
bugfix/noid/always-store-email-lowercase

Conversation

@nickvergessen

@nickvergessennickvergessen commented Dec 10, 2021

Copy link
Copy Markdown
Member
  1. Needs a database query executed on updating:
    UPDATE`oc_preferences`SET`configvalue`=LOWER(`configvalue`) WHERE`appid`='settings'AND`configkey`='email';
  2. Before merging into master, are the details stored somewhere else ❓
  3. Add a partial index for the first ~80 characters ❓
  4. Bump version number to trigger the migration

Signed-off-by: Joas Schilling <coding@schilljs.com>
Comment threadlib/private/AllConfig.php Outdated
@juliusknorr

juliusknorr commented Dec 10, 2021

Copy link
Copy Markdown
Member

Pushed an additional commit to use settings instead of core as the app id.

Ref

$userIds = $this->config->getUsersForUserValueCaseInsensitive('settings', 'email', $email);

@Pytal

Pytal commented Dec 10, 2021

Copy link
Copy Markdown
Member
  1. Bump version number to trigger the migration

Needs a version bump

@nickvergessennickvergessen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 13, 2021
@Pytal

Copy link
Copy Markdown
Member

Unhappy CI ⚙

@nickvergessen

nickvergessen commented Dec 13, 2021

Copy link
Copy Markdown
MemberAuthor

Please run: bash build/autoloaderchecker.sh
And commit the result

Can you do it?

nickvergessenand others added 4 commits December 13, 2021 19:20
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@Pytal
Pytalforce-pushed the bugfix/noid/always-store-email-lowercase branch from a2e80c3 to dbae781CompareDecember 13, 2021 19:20
@Pytal

Copy link
Copy Markdown
Member

⚙ failure unrelated

@Pytal
Pytal merged commit 09915ec into masterDec 14, 2021
@Pytal
Pytal deleted the bugfix/noid/always-store-email-lowercase branch December 14, 2021 00:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: authenticationperformance 🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@nickvergessen@juliusknorr@Pytal@ChristophWurst@skjnldsv@CarlSchwan