Skip to content

fix: revive always storing lowercased email addresses - #53615

Merged
st3iny merged 1 commit into
masterfrom
fix/revive-lowercase-email
Jun 24, 2025
Merged

fix: revive always storing lowercased email addresses#53615
st3iny merged 1 commit into
masterfrom
fix/revive-lowercase-email

Conversation

@st3iny

@st3inyst3iny commented Jun 20, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Summary

This fix was first implemented in #30197 but got lost.

Before: Mixed case emails (from LDAP) are saved as is in oc_preferences.
After: Mixed case emails are saved in lowercase in oc_preferences.

TODO

  • Needs a migration of existing broken values

Checklist

@st3inyst3iny self-assigned this Jun 20, 2025
@st3inyst3iny added this to the Nextcloud 32 milestone Jun 20, 2025
@st3iny

st3iny commented Jun 20, 2025

Copy link
Copy Markdown
MemberAuthor

/backport to stable31

@st3iny

This comment was marked as resolved.

Sign in to view
@st3inyst3iny added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 20, 2025
@st3iny
st3iny marked this pull request as ready for review June 20, 2025 08:31
@st3iny
st3iny requested a review from a team as a code ownerJune 20, 2025 08:31
@st3iny
st3iny requested review from Altahrim, ArtificialOwl, juliusknorr, nickvergessen and provokateurin and removed request for a teamJune 20, 2025 08:31
@st3inyst3iny mentioned this pull request Jun 20, 2025
Closed
5 tasks
nickvergessen
nickvergessen requested changes Jun 20, 2025
View reviewed changes
Comment threadlib/private/AllConfig.php Outdated
@st3inyst3iny added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jun 20, 2025
@st3iny
st3iny marked this pull request as draft June 20, 2025 11:19
@ArtificialOwl

ArtificialOwl commented Jun 20, 2025

Copy link
Copy Markdown
Member

@nickvergessen might be cool to have: #53619

@st3inyst3iny added the 3. to review Waiting for reviews label Jun 24, 2025
@st3iny
st3iny marked this pull request as ready for review June 24, 2025 10:05
@st3iny
fix: revive always storing lowercased email addresses
b6af06d
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny
st3inyforce-pushed the fix/revive-lowercase-email branch from 6d2b11f to b6af06dCompareJune 24, 2025 11:53
@st3inyst3iny changed the title fix: revive always storing lowercased email addresses in AllConfigfix: revive always storing lowercased email addressesJun 24, 2025
@st3inyst3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress 3. to review Waiting for reviews labels Jun 24, 2025
@st3iny
st3iny enabled auto-merge June 24, 2025 12:11
@st3iny
st3iny merged commit abced23 into masterJun 24, 2025
@st3iny
st3iny deleted the fix/revive-lowercase-email branch June 24, 2025 12:19
@github-project-automationgithub-project-automationBot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware teamJun 24, 2025
@backportbot

This comment was marked as resolved.

Sign in to view
@backportbotbackportbotBot mentioned this pull request Jun 24, 2025
Merged
2 tasks
@st3iny

st3iny commented Jun 24, 2025

Copy link
Copy Markdown
MemberAuthor

My bad, stable30 is not affected.

@skjnldsvskjnldsv mentioned this pull request Aug 19, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen approved these changes
@provokateurinprovokateurinprovokateurin approved these changes
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@AltahrimAltahrimAwaiting requested review from AltahrimAltahrim is a code owner automatically assigned from nextcloud/server-backend
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr

Assignees

@st3inyst3iny

Labels

4. to releaseReady to be released and/or waiting for tests to finishbackport-requestbugregression

Projects

💌 📅 👥 Groupware team
Archived in project

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

5 participants

@st3iny@ArtificialOwl@nickvergessen@provokateurin@skjnldsv