Uh oh!
There was an error while loading. Please reload this page.
Fix Calendar sends duplicate notifications if there is an additional attendee (#21370) - #30980
Fix Calendar sends duplicate notifications if there is an additional attendee (#21370)#30980kominoshja wants to merge 3 commits into
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
| ->join('cr', 'calendarobjects', 'co', $query->expr()->eq('cr.object_id', 'co.id')) | ||
| ->join('cr', 'calendars', 'c', $query->expr()->eq('cr.calendar_id', 'c.id')); | ||
| ->join('cr', 'calendars', 'c', $query->expr()->eq('cr.calendar_id', 'c.id')) | ||
| ->groupBy(['cr.event_hash','cr.type','cr.uid']); |
There was a problem hiding this comment.
This fails on some DB configurations:
https://dev.mysql.com/doc/refman/8.0/en/sql-mode.html#sqlmode_only_full_group_by
There was a problem hiding this comment.
good to know. I guess I have to do the grouping in memory.
There was a problem hiding this comment.
Select those columns on L67 as well, then you can still run this on the DB
There was a problem hiding this comment.
Select those columns on L67 as well
That's not right it. It's the other way around: All items that are selected need to be aggregated.
But I agree, if we previously did not group on db level, just group manually in php.
Irdiism
commented
Oct 4, 2023
This problem persists on NC25. Any plans to merge this patch? Thank you! |
skjnldsv
commented
Feb 27, 2024
Fixed already by #34909 |
The bug disclosed on #21370 still occurs on Nextcloud 23. The patch provided by @EhiOnime fixes this issue, but they never made a PR, so it continued to happen.