Uh oh!
There was an error while loading. Please reload this page.
Fix duplicate event email notifications - #34909
Merged
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
st3iny
marked this pull request as ready for review
November 4, 2022 12:49
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
tcitworld
approved these changes
Nov 4, 2022
ChristophWurst
approved these changes
Nov 4, 2022
st3iny
commented
Nov 4, 2022
MemberAuthor
/backport to stable25 |
st3iny
commented
Nov 4, 2022
MemberAuthor
/backport to stable24 |
st3iny
commented
Nov 4, 2022
MemberAuthor
/backport to stable23 |
st3iny
commented
Nov 4, 2022
MemberAuthor
/backport to stable22 |
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3inyforce-pushed
the
fix/21370/duplicate-notifications-2
branch
from
November 4, 2022 15:25
14f28c3 to
304b716Comparest3iny
commented
Nov 8, 2022
MemberAuthor
/backport to stable24 |
st3iny
commented
Nov 8, 2022
MemberAuthor
/backport to stable23 |
This was referenced Nov 8, 2022
st3iny
commented
Nov 8, 2022
MemberAuthor
/backport to stable22 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix#21370
This PR incorporates 2 fixes:
The email of the organizer was never extracted properly because the usage of-> Moved to a separate PR because it's not related.strcasecmp($organizer->getValue(), 'mailto:') !== 0was wrong. This lead to theReply-Toheader not being set.How to test
Preparations
occ config:app:set dav sendEventRemindersMode --value occRoutine
occ dav:send-event-reminders