Uh oh!
There was an error while loading. Please reload this page.
[stable11] popovermenu backport - #3286
Conversation
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
36c0927 to
9e7afbfCompareskjnldsv
commented
Feb 2, 2017
@nextcloud/designers bump |
codecov-io
commented
Feb 2, 2017
Codecov Report
@@ Coverage Diff @@## stable11 #3286 +/- ##
============================================
+ Coverage 57.13% 57.14% +<.01%
============================================
Files 1206 1206 Lines 72718 72718 Branches 1235 1235 ============================================
+ Hits 41550 41553 +3 + Misses 31168 31165 -3
Continue to review full report at Codecov.
|
skjnldsv
commented
Feb 5, 2017
Bump? 🐤 |
nickvergessen
commented
Feb 7, 2017
Backporting this will break all apps that use this? |
skjnldsv
commented
Feb 7, 2017
@nickvergessen no it should not change a thing since most of the app were sort of close to the css guidelines. But it will greatly increase compatibility between stable11 and 12 for the popover! :) |
LukasReschke
left a comment
There was a problem hiding this comment.
I'd say let's merge it for now and if we see massive problems in the RC we can revert it again.
skjnldsv
commented
Feb 10, 2017
Youhouuu! :D |
Backport of the corrected popovermenu.
Main ref: #3024#3118#3035
Additional ref: nextcloud/contacts#101
Tests: file action popover, calendar popover, user personal info privacy popover, mail account popover...
@nextcloud/designers