Uh oh!
There was an error while loading. Please reload this page.
Backend for reference metadata fetching - #33494
Conversation
Uh oh!
There was an error while loading. Please reload this page.
4b2fb66 to
445ea5fCompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
445ea5f to
84437c2CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
84437c2 to
7dba179Comparecome-nc
commented
Aug 29, 2022
It took me so long to understand what this is about, so, for other unaware reviewers: And this is the backend part, is not specific to Talk, and may not be specific to links in the future, which is what makes the original description convoluted. |
juliusknorr
commented
Aug 29, 2022
Sorry, should have clarified that a bit more, but I've taken your description for the first post in addition |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
424020a to
94ee906CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Julius Härtl <jus@bitgrid.net>
94ee906 to
1ab6698Comparejuliusknorr
commented
Aug 31, 2022
Failures unrelated |
| /** | ||
| * Return true if the reference metadata can be globally cached | ||
| * | ||
| * @since 25.0.0 | ||
| */ | ||
| public function getCachePrefix(string $referenceId): string; |
There was a problem hiding this comment.
The phpdoc description is wrong
Summary
This is about showing a preview of links posted in Talk, like what is done when posting links on other chat platforms.
And this is the backend part, is not specific to Talk, and may not be specific to links in the future, which is what makes the original description convoluted.
This PR implements an API to be used to generate a rich preview rendering of references (which are links in the first iteration). The backend gathers additional metadata for references through different providers, which can be added by apps, but there is a fallback to an open graph provider by default. The open graph extraction can be turned off through config.php.
ToDo
Backend
Integration
Provider implementations