File widget for references by juliusknorr · Pull Request #33755 · nextcloud/server

juliusknorr · 2022-08-30T13:19:02Z

Follow up to #33494 to implement the frontend for a files widget

julien-nc

Awesome. Some little remarks.

Also, how do we register a ReferenceProvider? I suppose there is an extra registerReferenceProvider to IRegistrationContext, right?

juliusknorr · 2022-09-01T17:49:47Z

Also, how do we register a ReferenceProvider? I suppose there is an extra registerReferenceProvider to IRegistrationContext, right?

Yes :)

juliusknorr · 2022-09-01T18:08:22Z

I've split the event out to get it in separately. #33818

julien-nc

🎉

marcelklehr

🐘

julien-nc

The dialog appears with padding in the picker modal:

I guess this can be partially solved in this implementation but would also maybe require adjustments in the picker implementation.

Also there are 2 close buttons, one from the picker, one from the dialog. We could hide the one from the dialog IMO.

julien-nc · 2023-03-02T10:10:28Z

@juliushaertl It seems that dist/files-reference-files.js is not included in your commits.
If I compile it locally, it loads but then the widget and custom picker are not registered and I get
[link picker] files reference provider is discoverable but does not have any related search provider or custom picker component registered in the browser console log.

julien-nc

Awesome!

Signed-off-by: Julius Härtl <jus@bitgrid.net>

…to different locations Signed-off-by: Julius Härtl <jus@bitgrid.net>

Signed-off-by: Julius Härtl <jus@bitgrid.net>

juliusknorr · 2023-03-02T21:15:09Z

Failures unrelated

juliusknorr changed the base branch from master to enh/referencesAugust 30, 2022 13:19

juliusknorr force-pushed the enh/references branch from 51ff9cf to 9fc1a90Compare August 30, 2022 18:02

juliusknorr force-pushed the enh/reference-file branch from 19cd0ea to e970316Compare August 30, 2022 18:55

juliusknorr mentioned this pull request Aug 30, 2022
Implement reference preview rendering nextcloud-libraries/vue-richtext#743
Merged
18 tasks

juliusknorr force-pushed the enh/references branch 2 times, most recently from 94ee906 to 1ab6698Compare August 31, 2022 16:03

juliusknorr force-pushed the enh/reference-file branch 2 times, most recently from 8c1abbb to 72d6655Compare August 31, 2022 18:08

Base automatically changed from enh/references to masterAugust 31, 2022 18:12

juliusknorr marked this pull request as ready for review August 31, 2022 18:17

juliusknorr force-pushed the enh/reference-file branch from 72d6655 to 6a6cf3aCompare August 31, 2022 18:17

juliusknorr requested review from CarlSchwan, julien-nc and nickvergessen August 31, 2022 18:17

juliusknorr added enhancement 3. to review Waiting for reviews labels Aug 31, 2022

juliusknorr added this to the Nextcloud 25 milestone Aug 31, 2022

juliusknorr mentioned this pull request Aug 31, 2022
Implement link previews nextcloud/spreed#7822
Merged
4 tasks

nickvergessen mentioned this pull request Aug 31, 2022
Handle event for Reference rendering nextcloud/spreed#7837
Closed

blizzz mentioned this pull request Sep 1, 2022
25.0.0 beta 4 #33762
Merged

julien-nc reviewed Sep 1, 2022
View reviewed changes

Comment threadapps/files/src/reference-files.js Outdated
Comment threadapps/files/src/views/ReferenceFileWidget.vue

juliusknorr force-pushed the enh/reference-file branch from 07acc77 to 6861179Compare September 1, 2022 18:05

juliusknorr force-pushed the enh/reference-file branch from 6861179 to 8f66f3cCompare September 1, 2022 18:10

julien-nc approved these changes Sep 2, 2022
View reviewed changes

juliusknorr force-pushed the enh/reference-file branch from 8f66f3c to 5b1e576Compare September 2, 2022 09:52

juliusknorr requested a review from max-nextcloud September 2, 2022 09:52

julien-nc mentioned this pull request Sep 2, 2022
Add API for other apps to show locations on the map nextcloud/maps#836
Open

blizzz mentioned this pull request Sep 6, 2022
25.0.0 beta 5 #33913
Merged

blizzz mentioned this pull request Sep 9, 2022
25.0.0 beta 6 #34002
Merged

skjnldsv mentioned this pull request Sep 15, 2022
25.0.0 beta 7 #34095
Merged

This was referenced Sep 20, 2022
25.0.0 beta 8 #34164
Closed
25.0.0 RC 1 #34185
Merged

blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022

nickvergessen mentioned this pull request Sep 22, 2022
Implement link widget thingy for /call/ urls nextcloud/spreed#7988
Closed

juliusknorr force-pushed the enh/reference-file branch from 5b1e576 to 363e890Compare September 26, 2022 10:13

PVince81 requested a review from icewind1991 November 4, 2022 16:47

juliusknorr force-pushed the enh/reference-file branch from 363e890 to ba54e5bCompare January 29, 2023 08:47

blizzz mentioned this pull request Feb 1, 2023
26.0.0 beta 2 #36484
Merged

skjnldsv mentioned this pull request Feb 23, 2023
26.0.0 beta 5 #36834
Merged

juliusknorr force-pushed the enh/reference-file branch from ba54e5b to 8b663d0Compare March 1, 2023 10:10

juliusknorr requested a review from marcelklehr March 1, 2023 10:15

marcelklehr approved these changes Mar 1, 2023
View reviewed changes

juliusknorr force-pushed the enh/reference-file branch from 81cca2d to 42099aaCompare March 1, 2023 11:21

julien-nc requested changes Mar 1, 2023
View reviewed changes

Comment threadapps/files/src/views/FileReferencePickerElement.vue Outdated
Comment threadapps/files/src/views/ReferenceFileWidget.vue

juliusknorr requested a review from julien-nc March 2, 2023 08:57

juliusknorr force-pushed the enh/reference-file branch from 42099aa to 51fa7f9Compare March 2, 2023 08:57

julien-nc approved these changes Mar 2, 2023
View reviewed changes

juliusknorr added 3 commits March 2, 2023 21:01

Implement file reference wiget
6130f1a
Signed-off-by: Julius Härtl <jus@bitgrid.net>

feat(filepicker): Allow to pass target for rendering the file picker …
1da4fe4
…to different locations Signed-off-by: Julius Härtl <jus@bitgrid.net>

chore: Bump bundles
38e4f8a
Signed-off-by: Julius Härtl <jus@bitgrid.net>

juliusknorr force-pushed the enh/reference-file branch from 0873256 to 38e4f8aCompare March 2, 2023 20:08

juliusknorr merged commit c76be65 into masterMar 2, 2023

juliusknorr deleted the enh/reference-file branch March 2, 2023 21:15

blizzz mentioned this pull request Mar 7, 2023
26.0.0 RC2 #37078
Merged

juliusknorr mentioned this pull request Mar 10, 2023
Issues when importing some functions from NcRichText.js nextcloud-libraries/nextcloud-vue#3864
Closed

Navigation Menu

Uh oh!

Uh oh!

File widget for references - #33755

File widget for references#33755
juliusknorr merged 3 commits into
masterfrom
enh/reference-file

juliusknorr commented Aug 30, 2022•
edited
Loading

Uh oh!

julien-nc left a comment

Uh oh!

Uh oh!

Uh oh!

juliusknorr commented Sep 1, 2022

Uh oh!

juliusknorr commented Sep 1, 2022

Uh oh!

julien-nc left a comment

Uh oh!

marcelklehr left a comment

Uh oh!

julien-nc left a comment

Uh oh!

Uh oh!

Uh oh!

julien-nc commented Mar 2, 2023

Uh oh!

julien-nc left a comment

Uh oh!

juliusknorr commented Mar 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

juliusknorr commented Aug 30, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

julien-nc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

juliusknorr commented Sep 1, 2022

Uh oh!

juliusknorr commented Sep 1, 2022

Uh oh!

julien-nc left a comment

Choose a reason for hiding this comment

Uh oh!

marcelklehr left a comment

Choose a reason for hiding this comment

Uh oh!

julien-nc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

julien-nc commented Mar 2, 2023

Uh oh!

julien-nc left a comment

Choose a reason for hiding this comment

Uh oh!

juliusknorr commented Mar 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

juliusknorr commented Aug 30, 2022•
edited
Loading