Skip to content

handle cases where SharedStorage::init isn't initializing the storage - #33985

Closed
icewind1991 wants to merge 3 commits into
masterfrom
share-null-source
Closed

handle cases where SharedStorage::init isn't initializing the storage#33985
icewind1991 wants to merge 3 commits into
masterfrom
share-null-source

Conversation

@icewind1991

@icewind1991icewind1991 commented Sep 8, 2022

Copy link
Copy Markdown
Member

Signed-off-by: Robin Appelman robin@icewind.nl

@icewind1991icewind1991 added the 2. developing Work in progress label Sep 8, 2022
github-advanced-security[bot]
github-advanced-securityAI found potential problems Sep 8, 2022
View reviewed changes
Comment threadapps/files_sharing/lib/SharedStorage.php Fixed
Comment threadapps/files_sharing/lib/SharedStorage.php Fixed
github-advanced-security[bot]
github-advanced-securityAI found potential problems Sep 15, 2022
View reviewed changes
Comment threadapps/files_sharing/lib/SharedStorage.php Fixed
Comment threadapps/files_sharing/lib/SharedStorage.php Fixed
Comment threadapps/files_sharing/lib/SharedStorage.php Fixed
github-advanced-security[bot]
github-advanced-securityAI found potential problems Sep 15, 2022
View reviewed changes
Comment threadapps/files_sharing/lib/SharedStorage.php Fixed
Comment threadapps/files_sharing/lib/SharedStorage.php Fixed
@icewind1991
icewind1991force-pushed the share-null-source branch 2 times, most recently from f257fa5 to 53de49bCompareSeptember 16, 2022 13:17
@icewind1991icewind1991 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 16, 2022
@icewind1991
icewind1991 requested review from a team, CarlSchwan, PVince81 and skjnldsv and removed request for a teamSeptember 16, 2022 17:49
@PVince81

PVince81 commented Sep 19, 2022

Copy link
Copy Markdown
Member

weird:

1) OCA\Provisioning_API\Tests\Controller\UsersControllerTest::testAddUserAlreadyExisting
Failed asserting that exception of type "Error" matches expected exception "OCP\AppFramework\OCS\OCSException". Message was: "Call to a member function t() on null" at
/drone/src/apps/provisioning_api/lib/Controller/UsersController.php:353
/drone/src/apps/provisioning_api/tests/Controller/UsersControllerTest.php:271
.

@PVince81
PVince81 requested a review from PytalSeptember 19, 2022 12:51
@PVince81PVince81 added this to the Nextcloud 25 milestone Sep 19, 2022
@PVince81

PVince81 commented Sep 19, 2022

Copy link
Copy Markdown
Member

/rebase

@blizzzblizzz mentioned this pull request Sep 19, 2022
Merged
@icewind1991@PVince81
handle cases where SharedStorage::init isn't initializing the storage
21f09ad
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991@PVince81
also set nonMaskedStorage when shared setup fails
0f617e7
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991@PVince81
switch to new logger interface
d20b53b
Signed-off-by: Robin Appelman <robin@icewind.nl>
@Pytal

Pytal commented Sep 19, 2022

Copy link
Copy Markdown
Member
1) OCA\Provisioning_API\Tests\Controller\UsersControllerTest::testAddUserAlreadyExisting
Failed asserting that exception of type "Error" matches expected exception "OCP\AppFramework\OCS\OCSException". Message was: "Call to a member function t() on null" at
/drone/src/apps/provisioning_api/lib/Controller/UsersController.php:353
/drone/src/apps/provisioning_api/tests/Controller/UsersControllerTest.php:271
.

Fixed on master in 4de19e9

Pytal
Pytal reviewed Sep 19, 2022
View reviewed changes
Comment threadapps/files_sharing/lib/SharedStorage.php
public function getWrapperStorage() {
$this->init();

// `init` should handle this, but apparently it sometimes doesn't

@PytalPytalSep 19, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the reason for why it doesn't known?

This was referenced Sep 20, 2022
Closed
Merged
@blizzzblizzz modified the milestones: Nextcloud 25, Nextcloud 26Sep 22, 2022
@PVince81

PVince81 commented Dec 16, 2022

Copy link
Copy Markdown
Member

@icewind1991 is this still valid or did we fix this in a different way ? possibly through #35218

This was referenced May 9, 2023
Closed
Merged
@skjnldsvskjnldsv mentioned this pull request Nov 1, 2023
Merged
This was referenced Nov 6, 2023
Merged
Merged
This was referenced Nov 14, 2023
Merged
Merged
@blizzzblizzz modified the milestones: Nextcloud 28, Nextcloud 29Nov 23, 2023
This was referenced Mar 12, 2024
Merged
Merged
Merged
This was referenced Mar 20, 2024
Merged
Merged
@skjnldsvskjnldsv mentioned this pull request Mar 28, 2024
Merged
81 tasks
@skjnldsvskjnldsv added 2. developing Work in progress stale Ticket or PR with no recent activity and removed 3. to review Waiting for reviews labels Jul 27, 2024
This was referenced Jul 30, 2024
Merged
Merged
This was referenced Aug 5, 2024
Merged
Merged
@skjnldsvskjnldsv mentioned this pull request Aug 13, 2024
Merged
@skjnldsvskjnldsv removed this from the Nextcloud 30 milestone Aug 14, 2024
@skjnldsv
skjnldsv deleted the share-null-source branch August 30, 2024 07:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PytalPytalPytal left review comments
@PVince81PVince81Awaiting requested review from PVince81
@skjnldsvskjnldsvAwaiting requested review from skjnldsv
@CarlSchwanCarlSchwanAwaiting requested review from CarlSchwan

Assignees

No one assigned

Labels

2. developingWork in progressfeature: sharingstaleTicket or PR with no recent activity

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@icewind1991@PVince81@Pytal@github-advanced-security@blizzz@skjnldsv