Uh oh!
There was an error while loading. Please reload this page.
delay updating setup providers untill we register the mounts - #35218
Conversation
SystemKeeper
commented
Nov 16, 2022
Tested and works in my case 👍 Thank you! |
SystemKeeper
commented
Nov 16, 2022
Is there a chance that this patch introduces performances issues? So the user which wasn't able to see shares from other users can now see them again. But now the user which did not have any issues, sometimes can't load the "/Talk" directory (sometimes it times out while the php-fpm process is running at 100%, sometimes it shows the files after loading for ever, sometimes it shows the wrong files). Also opening the dashboard or talk is really slow as well (talking > 60s). Reverting the patch immediately restores performance?! |
SystemKeeper
commented
Nov 16, 2022
These queries keep repeating when accessing the "/Talk" folder: |
icewind1991
commented
Nov 16, 2022
Failing tests also seem to indicate a loop somewhere, will look into it tomorrow, thanks for testing |
Uh oh!
There was an error while loading. Please reload this page.
otherwise the fallback to a full setup for a missing cached mount provider will lead to a race condition Signed-off-by: Robin Appelman <robin@icewind.nl>
b2f9852 to
841a6a0Compareicewind1991
commented
Nov 17, 2022
@SystemKeeper can you check if the latest version of the PR fixes your performance issues |
SystemKeeper
commented
Nov 17, 2022
Tested and works for me now correctly 👍 |
szaimen
commented
Nov 18, 2022
/backport to stable25 |
szaimen
commented
Nov 18, 2022
/backport to stable24 |
PVince81
commented
Nov 18, 2022
someone reported that this PR ("the patch") breaks collectives, @icewind1991 can you verify ? |
XueSheng-GIT
commented
Nov 18, 2022
It turned out, that the latest version of this pull works just fine with Collectives. I was still using the previous/outdated diff (2 days ago). I've updated #34752 (comment) accordingly. |
szaimen
left a comment
There was a problem hiding this comment.
Community confirmed that it works
otherwise the fallback to a full setup for a missing cached mount provider will lead to a race condition
Signed-off-by: Robin Appelman robin@icewind.nl
Fix#34752