Skip to content

fix public view - #34028

Merged
szaimen merged 2 commits into
masterfrom
enh/33803/public-view
Sep 13, 2022
Merged

fix public view#34028
szaimen merged 2 commits into
masterfrom
enh/33803/public-view

Conversation

@szaimen

@szaimenszaimen commented Sep 12, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Close#33858
Close#33803

Signed-off-by: szaimen szaimen@e.mail.de

@szaimenszaimen added the 2. developing Work in progress label Sep 12, 2022
@szaimen

szaimen commented Sep 12, 2022

Copy link
Copy Markdown
ContributorAuthor

/compile /

@szaimen
szaimenforce-pushed the enh/33803/public-view branch from abdc077 to a83bf64CompareSeptember 12, 2022 12:04
@szaimen

szaimen commented Sep 12, 2022

Copy link
Copy Markdown
ContributorAuthor

/compile /

@szaimenszaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 12, 2022
@szaimen
szaimen requested review from a team, CarlSchwan, PVince81, Pytal, juliusknorr, max-nextcloud and skjnldsv and removed request for a teamSeptember 12, 2022 12:26
@szaimenszaimen added this to the Nextcloud 25 milestone Sep 12, 2022
@szaimen
szaimen marked this pull request as ready for review September 12, 2022 12:26
@szaimen
szaimenforce-pushed the enh/33803/public-view branch from c54f88e to 6d431c8CompareSeptember 12, 2022 13:31
@szaimen

szaimen commented Sep 12, 2022

Copy link
Copy Markdown
ContributorAuthor

/compile amend /

@max-nextcloud

max-nextcloud commented Sep 12, 2022

Copy link
Copy Markdown
Contributor

thanks for looking into this!
Haven't had time yet to try it out.

@szaimen
szaimenforce-pushed the enh/33803/public-view branch from 6d431c8 to 2432df5CompareSeptember 12, 2022 13:58
@szaimen

szaimen commented Sep 12, 2022

Copy link
Copy Markdown
ContributorAuthor

/compile amend /

@szaimen
szaimenforce-pushed the enh/33803/public-view branch from ca91803 to a922b12CompareSeptember 12, 2022 20:34
@szaimen

szaimen commented Sep 12, 2022

Copy link
Copy Markdown
ContributorAuthor

/compile amend /

skjnldsv
skjnldsv reviewed Sep 13, 2022
View reviewed changes
Comment threadapps/files_sharing/css/public.scss

#imgframe img {
max-height: 100% !important;
max-height: calc(100vh - var(--header-height) - #{$footer-height} - #{$download-button-section-height}) !important;

@skjnldsvskjnldsvSep 13, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow 🙈

@szaimenszaimenSep 13, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have better ideas? Other solutions didnt work in my testing...

PVince81
PVince81 approved these changes Sep 13, 2022
View reviewed changes

@PVince81PVince81 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

skjnldsv
skjnldsv reviewed Sep 13, 2022
View reviewed changes
Comment threadapps/files_sharing/css/public.scss
}

#imgframe video {
max-height: calc(100vh - var(--header-height) - #{$footer-height} - #{$download-button-section-height});

@skjnldsvskjnldsvSep 13, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it still relevant?
Considering we're using the viewer now to render single files shares?

@szaimenszaimenSep 13, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this was needed to make it work with any screen size...

@skjnldsvskjnldsvSep 13, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHould it not be handled widely then? Make the viewer container takign the full size?
Not just video or img tags

@szaimenszaimenSep 13, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't find other formats that would need fixing so only applied it to these.

@szaimenszaimenSep 13, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw: public audio playback is currently broken IIRC: #34027

@max-nextcloudmax-nextcloudSep 13, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm working on a separate PR for audio playback here #34051 - would style that after this is merged.

@szaimen
fix public view
10ad6e1
Signed-off-by: szaimen <szaimen@e.mail.de>
@szaimen
szaimenforce-pushed the enh/33803/public-view branch from 150441c to b664644CompareSeptember 13, 2022 13:00
@szaimenszaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 13, 2022
@szaimen

szaimen commented Sep 13, 2022

Copy link
Copy Markdown
ContributorAuthor

/compile amend /

@szaimenszaimen mentioned this pull request Sep 13, 2022
Merged
2 tasks
@nextcloud-command
Compile assets
335964d
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@szaimen

szaimen commented Sep 13, 2022

Copy link
Copy Markdown
ContributorAuthor

CI failure unrelated

@szaimen
szaimen merged commit b739dd5 into masterSep 13, 2022
@szaimen
szaimen deleted the enh/33803/public-view branch September 13, 2022 14:08
@skjnldsvskjnldsv mentioned this pull request Sep 15, 2022
Merged
@szaimenszaimen mentioned this pull request Apr 17, 2023
Closed
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsvskjnldsvskjnldsv left review comments
@PVince81PVince81PVince81 approved these changes
@max-nextcloudmax-nextcloudmax-nextcloud approved these changes
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr
@CarlSchwanCarlSchwanAwaiting requested review from CarlSchwan
@PytalPytalAwaiting requested review from Pytal

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 25

Development

Successfully merging this pull request may close these issues.

sharing view needs a bit of rework BUG: public link image share, footer overlaps with scrollbar:

5 participants

@szaimen@max-nextcloud@PVince81@skjnldsv@nextcloud-command