Skip to content

fix: play single audio shares with the viewer - #34051

Merged
szaimen merged 1 commit into
masterfrom
fix/34027/play-audio
Sep 13, 2022
Merged

fix: play single audio shares with the viewer#34051
szaimen merged 1 commit into
masterfrom
fix/34027/play-audio

Conversation

@max-nextcloud

@max-nextcloudmax-nextcloud commented Sep 13, 2022•
edited by szaimen
Loading

Copy link
Copy Markdown
Contributor

Use the viewer to play audio files.

Close#34027

@max-nextcloud
fix: play single audio shares with the viewer
d8ff712
Signed-off-by: Max <max@nextcloud.com>
@max-nextcloudmax-nextcloud mentioned this pull request Sep 13, 2022
Merged
@szaimenszaimen added this to the Nextcloud 25 milestone Sep 13, 2022
@szaimen

szaimen commented Sep 13, 2022

Copy link
Copy Markdown
Contributor

Needs a rebase after #34028 is merged

skjnldsv
skjnldsv reviewed Sep 13, 2022
View reviewed changes
Comment threadapps/files_sharing/js/public.js

if (OCA.Viewer && OCA.Viewer.mimetypes.includes(mimetype)
&& (mimetype.startsWith('image/') || mimetype.startsWith('video/'))) {
&& (mimetype.startsWith('image/') || mimetype.startsWith('video/') || mimetype.startsWith('audio'))) {

@skjnldsvskjnldsvSep 13, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use the supported Viewer mimes?

@max-nextcloudmax-nextcloudSep 14, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text has its own hook into files_sharing and does a bunch of tweaks there for the ui.
I have not been able to figure out a good way to use viewer with the text component in this context without larger rewrites.

I agree it would be cleaner.

My understanding is that we are mostly doing this to enable video playback and it should be backported to earlier versions (22 at the time but now at least 24). So I tried to keep changes minimal.

@max-nextcloud

max-nextcloud commented Sep 13, 2022

Copy link
Copy Markdown
ContributorAuthor

Looks like the styling in the viewer relies on viewer__content to align the player in the middle. Maybe we should also have that when rendering the viewer in an element other than the modal.

@szaimen

szaimen commented Sep 13, 2022

Copy link
Copy Markdown
Contributor

Looks like the styling in the viewer relies on viewer__content to align the player in the middle. Maybe we should also have that when rendering the viewer in an element other than the modal.

lets have a look at the styling after #34028 is merged. However sounds like a good approach.

@szaimen
szaimen merged commit 7e6dffd into masterSep 13, 2022
@szaimen
szaimen deleted the fix/34027/play-audio branch September 13, 2022 13:41
@szaimen
szaimen restored the fix/34027/play-audio branch September 13, 2022 13:41
@szaimenszaimen mentioned this pull request Sep 13, 2022
Closed
@szaimen

szaimen commented Sep 13, 2022

Copy link
Copy Markdown
Contributor

Sorry, was on a different PR in my head...

@szaimen

szaimen commented Sep 13, 2022

Copy link
Copy Markdown
Contributor

Or rather lets do the CSS improvements in a follow up...

@szaimen
szaimen deleted the fix/34027/play-audio branch September 13, 2022 13:43
@szaimen

szaimen commented Sep 13, 2022

Copy link
Copy Markdown
Contributor

Will have a look at the styling now. @max-nextcloud@skjnldsv do you want to refactor the mimetype handling still?

@szaimen

szaimen commented Sep 13, 2022

Copy link
Copy Markdown
Contributor

Style fixes are in #34055

@szaimenszaimen mentioned this pull request Sep 13, 2022
Merged
@skjnldsvskjnldsv mentioned this pull request Sep 15, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsvskjnldsvskjnldsv left review comments

Assignees

No one assigned

Labels

2. developingWork in progress

Projects

None yet

Milestone

Nextcloud 25

Development

Successfully merging this pull request may close these issues.

external audio playback is broken

3 participants

@max-nextcloud@szaimen@skjnldsv