Uh oh!
There was an error while loading. Please reload this page.
Rename users to account or person - #34178
Conversation
8d4de1e to
79d887bComparePVince81
commented
Sep 21, 2022
I've fixed the unit tests locally, I'll push after I see the acceptance test results... some rely on texts/labels sometimes |
PVince81
commented
Sep 21, 2022
79d887b to
3136a35ComparePVince81
commented
Sep 21, 2022
I've pushed even more renames here |
PVince81
commented
Sep 21, 2022
/compile amend / |
3136a35 to
82ace7dCompare42e100f to
83fc72aComparePVince81
commented
Sep 22, 2022
as it's a bit late considering the string freeze and also the fact that other apps need adjusting as well, let's not merge this for 25.0.0 but 25.0.1 could do this would give us time also to properly review all the strings that were replaced and see how they look like in context |
jancborchardt
commented
Oct 11, 2022
Where is "user status" used in these cases? Cause just "Status" might be enough? "the status feature", "set your status", "people can set their status" etc. For "user documentation" → "Usage documentation". German equivalent would be "Benutzerhandbuch" → "Benutzungshandbuch". |
PVince81
commented
Oct 19, 2022
@jancborchardt I rechecked and it seems the only place where "User status" is visible is for admins as it's the name of the app that can be disabled. And it appears in few debug messages, but that's all. Should we leave it as is ? |
83fc72a to
8b50e5eComparePVince81
commented
Oct 19, 2022
Rebased and renamed "User documentation" to "Usage documentation" |
b7cf9e6 to
5a2ca05Compare| if (!isset($parsedParameters['user'])) { | ||
| // External user via public link share | ||
| $subject = str_replace('{user}', $this->activityLang->t('"remote user"'), $subject); | ||
| $subject = str_replace('{user}', $this->activityLang->t('"remote person"'), $subject); |
There was a problem hiding this comment.
@jancborchardt for feedback
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as resolved.
This comment was marked as resolved.
2858f49 to
693e2cfCompareaa2c934 to
42d99d1Compare42d99d1 to
a00b92fCompareReplace translated text in most locations Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
a00b92f to
524ed97Compare
Replace translated texts from "user" to either "account" or "people" depending on context
Resolves#32720