Skip to content

chore(settings): Change "user" to "account" - #45398

Merged
szaimen merged 6 commits into
masterfrom
chore/account-name
May 21, 2024
Merged

chore(settings): Change "user" to "account"#45398
szaimen merged 6 commits into
masterfrom
chore/account-name

Conversation

@Pytal

@PytalPytal commented May 17, 2024

Copy link
Copy Markdown
Member

Summary

Screenshots
image
image
image

Checklist

Pytal added 5 commits May 17, 2024 10:15
@Pytal
chore(settings): Change "username" to "account name"
5b260ff
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
chore(core): Change "username" to "account name"
0bd3846
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
chore: Rename "Users" menu entry to "Accounts"
a7a8fee
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
chore(settings): Rename "User backend" to "Account backend"
6815d5b
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
chore: compile assets
9f3b892
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@PytalPytal added design Design, UI, UX, etc. 3. to review Waiting for reviews labels May 17, 2024
@PytalPytal added this to the Nextcloud 30 milestone May 17, 2024
@PytalPytal self-assigned this May 17, 2024
szaimen
szaimen reviewed May 17, 2024
View reviewed changes
Comment threadcore/src/components/login/LoginForm.vue
szaimen
szaimen reviewed May 17, 2024
View reviewed changes
Comment threadcore/src/components/login/LoginForm.vue
@szaimenszaimen mentioned this pull request May 21, 2024
Merged
szaimen
szaimen approved these changes May 21, 2024
View reviewed changes

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@szaimen
fix: cypress
31e8a14
Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen
szaimenforce-pushed the chore/account-name branch from 1390fe6 to 31e8a14CompareMay 21, 2024 08:27
@szaimen
szaimen enabled auto-merge May 21, 2024 08:27
@szaimen
szaimen merged commit 5a6e48e into masterMay 21, 2024
@szaimen
szaimen deleted the chore/account-name branch May 21, 2024 09:05
@blizzzblizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsvskjnldsvskjnldsv approved these changes
@szaimenszaimenszaimen approved these changes
@jancborchardtjancborchardtAwaiting requested review from jancborchardt

Assignees

@PytalPytal

Labels

3. to reviewWaiting for reviewsdesignDesign, UI, UX, etc.

Projects

🖍 Design team
Archived in project

Milestone

Nextcloud 30

Development

Successfully merging this pull request may close these issues.

3 participants

@Pytal@skjnldsv@szaimen