Skip to content

[stable23] Rename personal Groupware settings section to "Availability" - #34763

Closed
backportbot-nextcloud[bot] wants to merge 1 commit into
stable23from
backport/34626/stable23
Closed

[stable23] Rename personal Groupware settings section to "Availability"#34763
backportbot-nextcloud[bot] wants to merge 1 commit into
stable23from
backport/34626/stable23

Conversation

@backportbot-nextcloud

@backportbot-nextcloudbackportbot-nextcloudBot commented Oct 24, 2022

Copy link
Copy Markdown

backport of #34626

@ChristophWurst@backportbot-nextcloud
Rename personal Groupware settings section to "Availability"
a7c6597
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@backportbot-nextcloudbackportbot-nextcloudBot added the pending documentation This pull request needs an associated documentation update label Oct 24, 2022
ChristophWurst
ChristophWurst requested changes Oct 24, 2022
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#34626 (comment) this change is potentially breaking

@skjnldsvskjnldsv mentioned this pull request Oct 27, 2022
Merged
@nickvergessennickvergessen removed the pending documentation This pull request needs an associated documentation update label Nov 8, 2022
@blizzzblizzz mentioned this pull request Nov 21, 2022
Merged
8 tasks
@blizzz

blizzz commented Nov 23, 2022

Copy link
Copy Markdown
Member

Then let's not do it for 23 at all, k?

@blizzzblizzz mentioned this pull request Nov 29, 2022
Merged
8 tasks
@ChristophWurst

ChristophWurst commented Nov 29, 2022

Copy link
Copy Markdown
Member

@AndyScherzinger I would vote against backporting the code identifier changes as they could break any apps that show a setting section on the groupware page.

If renaming is important for older releases we could only touch the UI string and leave the internal identifier. That means app sections can still be rendered. In the worst case they show on a page that semantically doesn't fit their purpose because groupware no longer shows Groupware settings but Availability settings.

It's the lesser of the two evils though :)

@AndyScherzinger

AndyScherzinger commented Nov 29, 2022

Copy link
Copy Markdown
Member

for older releases we could only touch the UI string and leave the internal identifier

fine by me as a solution @ChristophWurst

@blizzzblizzz mentioned this pull request Dec 8, 2022
Merged
@blizzzblizzz removed this from the Nextcloud 23.0.12 milestone Dec 8, 2022
@PVince81

PVince81 commented Dec 16, 2022

Copy link
Copy Markdown
Member

23 is EOL

@ChristophWurst
ChristophWurst deleted the backport/34626/stable23 branch December 16, 2022 16:34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurstChristophWurstChristophWurst requested changes
@AndyScherzingerAndyScherzingerAwaiting requested review from AndyScherzinger
@CarlSchwanCarlSchwanAwaiting requested review from CarlSchwan
@jancborchardtjancborchardtAwaiting requested review from jancborchardt
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@tcitworldtcitworldAwaiting requested review from tcitworld

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@blizzz@ChristophWurst@AndyScherzinger@PVince81@nickvergessen@skjnldsv