Skip to content

Rename personal Groupware settings section to "Availability" - #34626

Merged
ChristophWurst merged 1 commit into
masterfrom
enhancement/rename-personal-groupware-settings-section-availability
Oct 24, 2022
Merged

Rename personal Groupware settings section to "Availability"#34626
ChristophWurst merged 1 commit into
masterfrom
enhancement/rename-personal-groupware-settings-section-availability

Conversation

@ChristophWurst

@ChristophWurstChristophWurst commented Oct 17, 2022

Copy link
Copy Markdown
Member

As discussed internally.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurstChristophWurst added 3. to review Waiting for reviews pending documentation This pull request needs an associated documentation update labels Oct 17, 2022
@ChristophWurstChristophWurst added this to the Nextcloud 26 milestone Oct 17, 2022
@ChristophWurstChristophWurst self-assigned this Oct 17, 2022
@ChristophWurstChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 17, 2022
@tcitworld

Copy link
Copy Markdown
Member

There's a number of calendar-related settings that should come to this section in the future: #33397nextcloud/calendar#4310.

These are really unrelated to availability, so it wouldn't make much sense to rename it afterwards. Should they use another section?

@ChristophWurst

ChristophWurst commented Oct 17, 2022

Copy link
Copy Markdown
MemberAuthor

Should they use another section?

I would say yes

@AndyScherzinger

Copy link
Copy Markdown
Member

/backport to stable25

@AndyScherzinger

Copy link
Copy Markdown
Member

/backport to stable24

@AndyScherzinger

Copy link
Copy Markdown
Member

/backport to stable23

@ChristophWurst

Copy link
Copy Markdown
MemberAuthor

I scanned our own apps for settings sections that rendered on the old groupware page. If there are any other apps that make use of the section then the backport will break them.

@AndyScherzinger

Copy link
Copy Markdown
Member

@ChristophWurst so for the backport we could the just do the label and icon change but not the file renames? Or is the issue with the label too?

@ChristophWurst

Copy link
Copy Markdown
MemberAuthor

@ChristophWurst so for the backport we could the just do the label and icon change but not the file renames? Or is the issue with the label too?

There is a human readable label that we can change. We can leave the code label to "groupware". The only strange situation we could create is that groupware-related settings would show in "Availability".

This is also the reason why I've added the documentation label. We have to warn app devs about this change in 26.

@jancborchardt

Copy link
Copy Markdown
Member

There's a number of calendar-related settings that should come to this section in the future: #33397nextcloud/calendar#4310.
These are really unrelated to availability, so it wouldn't make much sense to rename it afterwards. Should they use another section?

Thanks for pointing these out – FYI the first one should be in Calendar rather than Personal settings, and the second one shouldn’t be a setting but automatic. I commented on both to that effect. :)

@AndyScherzinger

Copy link
Copy Markdown
Member

Makes sense and due to @ChristophWurst comment about app devs I think it makes sense to start a ticket to track any app changes relevant for communication to app devs right away, just to have it in place right from the start of v26

tcitworld added a commit that referenced this pull request Oct 22, 2022
In replacement of the removed Groupware settings section in #34626
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
tcitworld added a commit that referenced this pull request Oct 22, 2022
In replacement of the removed Groupware settings section in #34626
Signed-off-by: Thomas Citharel <tcit@tcit.fr>

@tcitworldtcitworld left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: oops, confused admin sections with personal sections

tcitworld added a commit that referenced this pull request Oct 22, 2022
In replacement of the removed Groupware settings section in #34626
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
tcitworld added a commit that referenced this pull request Oct 22, 2022
In replacement of the removed Groupware settings section in #34626
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
tcitworld added a commit that referenced this pull request Oct 22, 2022
In replacement of the removed Groupware settings section in #34626
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@ChristophWurst
ChristophWurst merged commit 232c760 into masterOct 24, 2022
@ChristophWurst
ChristophWurst deleted the enhancement/rename-personal-groupware-settings-section-availability branch October 24, 2022 08:13
tcitworld added a commit that referenced this pull request Oct 24, 2022
In replacement of the removed Groupware settings section in #34626
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@ChristophWurstChristophWurst removed the pending documentation This pull request needs an associated documentation update label Oct 24, 2022
@ChristophWurst

Copy link
Copy Markdown
MemberAuthor

Documented at nextcloud/documentation#9249

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finish

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants

@ChristophWurst@tcitworld@AndyScherzinger@jancborchardt@nickvergessen@CarlSchwan