Uh oh!
There was an error while loading. Please reload this page.
Menu elements not displayed as block - #34886
Closed
Dennis1993 wants to merge 4 commits into
Closed
Conversation
Signed-off-by: Dennis1993 <Dennis1993@users.noreply.github.com>
Signed-off-by: Dennis1993 <Dennis1993@users.noreply.github.com>
Signed-off-by: Dennis1993 <Dennis1993@users.noreply.github.com>
szaimen
requested review from
a team, PVince81, skjnldsv and szaimen
and removed request for
a teamOctober 30, 2022 16:55
szaimen
commented
Oct 30, 2022
Contributor
/backport to stable25 |
szaimen
commented
Oct 30, 2022
Contributor
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Pytal
commented
Nov 2, 2022
Member
From my testing this would reintroduce #33857 So I suggest we restore the deleted snippet and scope it like ...
.popovermenu {
&:not(.fileActionsMenu) {
li {
> button,
> a,
> .menuitem {
width: fit-content;
/* DEPRECATED! old img in popover fallback * TODO: to remove */
> img {
width: $popoveritem-height;
height: $popoveritem-height;
}
}
}
}
}
...The DEPRECATED part introduced in #11054 doesn't seem to apply anymore, at least in the files sharing sidebar, but would need @danxuliu to confirm |
szaimen
commented
Nov 8, 2022
Contributor
@nextcloud/server-frontend how to continue with this? |
43 tasks
szaimen
commented
Nov 10, 2022
Contributor
I'd vote for Chris' proposal. @Pytal can you take this over? :) |
PVince81
commented
Nov 14, 2022
Member
@skjnldsv please take over |
szaimen
commented
Nov 24, 2022
Contributor
Ping @skjnldsv ? :) |
szaimen
commented
Nov 24, 2022
Contributor
szaimen
commented
Nov 24, 2022
Contributor
hm... I just tried the latest 25 with And I somehow cannot reproduce the problem. It seems to work... But really no idea what has fixed it... |
This was referenced Nov 25, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close#34653
Close#35153
Fix for #34870 to set the width to 100% for all elements.