Skip to content

fix the popovermenu - #35484

Merged
szaimen merged 1 commit into
masterfrom
fix/34653/fix-popover-menu
Nov 30, 2022
Merged

fix the popovermenu#35484
szaimen merged 1 commit into
masterfrom
fix/34653/fix-popover-menu

Conversation

@szaimen

@szaimenszaimen commented Nov 29, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Fix#34653
Fix#35153
Close#34886
Supersedes #34886

Signed-off-by: Simon L szaimen@e.mail.de

For my own testing
docker run -it \
--name nextcloud-easy-test \
-p 8443:443 \
-e TRUSTED_DOMAIN=192.168.24.128 \
-e SERVER_BRANCH=fix/34653/fix-popover-menu \
--volume="nextcloud_easy_test_npm_cache_volume:/var/www/.npm" \
-e RIGHTCLICK_BRANCH=master \
-e COMPILE_SERVER=1 \
ghcr.io/szaimen/nextcloud-easy-test:latest

@szaimenszaimen added the 2. developing Work in progress label Nov 29, 2022
@szaimenszaimen added this to the Nextcloud 26 milestone Nov 29, 2022
@szaimen
szaimenforce-pushed the fix/34653/fix-popover-menu branch from 96b20d3 to e11bd0cCompareNovember 29, 2022 11:38
@szaimen

szaimen commented Nov 29, 2022

Copy link
Copy Markdown
ContributorAuthor

/compile amend /

@szaimen
szaimen marked this pull request as ready for review November 29, 2022 11:42
@szaimenszaimen changed the title try to fix the popovermenufix the popovermenuNov 29, 2022
@szaimenszaimen added bug 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 29, 2022
@szaimen
szaimen requested review from a team, Pytal, artonge, mejo- and skjnldsv and removed request for a teamNovember 29, 2022 11:43
@szaimen

szaimen commented Nov 29, 2022

Copy link
Copy Markdown
ContributorAuthor

/backport to stable25

@szaimenszaimen mentioned this pull request Nov 29, 2022
Closed
9 tasks
mejo-
mejo- approved these changes Nov 29, 2022
View reviewed changes

@mejo-mejo- left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for looking into this @szaimen <3

I didn't test it, but codewise it looks good to me.

@szaimen
szaimenforce-pushed the fix/34653/fix-popover-menu branch from c9dc895 to a6ac209CompareNovember 29, 2022 12:05
@szaimen

szaimen commented Nov 29, 2022

Copy link
Copy Markdown
ContributorAuthor

/compile amend /

@szaimen@nextcloud-command
try to fix the popovermenu
f889007
Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
CarlSchwan
CarlSchwan approved these changes Nov 30, 2022
View reviewed changes

@CarlSchwanCarlSchwan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@szaimen

szaimen commented Nov 30, 2022

Copy link
Copy Markdown
ContributorAuthor

CI failure unrelated

@szaimen
szaimen merged commit 415e68f into masterNov 30, 2022
@szaimen
szaimen deleted the fix/34653/fix-popover-menu branch November 30, 2022 11:20
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Nov 30, 2022
Merged
1 task
@szaimenszaimen mentioned this pull request Feb 24, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mejo-mejo-mejo- approved these changes
@CarlSchwanCarlSchwanCarlSchwan approved these changes
@skjnldsvskjnldsvAwaiting requested review from skjnldsv
@artongeartongeAwaiting requested review from artonge
@PytalPytalAwaiting requested review from Pytal

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

[Bug]: Context menu too narrow for text when triggered from grid view [Bug]: File actions menu links don't span over whole menu width

3 participants

@szaimen@mejo-@CarlSchwan