Skip to content

[stable24] delay updating setup providers untill we register the mounts - #35258

Merged
szaimen merged 1 commit into
stable24from
backport/35218/stable24
Nov 18, 2022
Merged

[stable24] delay updating setup providers untill we register the mounts#35258
szaimen merged 1 commit into
stable24from
backport/35218/stable24

Conversation

@backportbot-nextcloud

@backportbot-nextcloudbackportbot-nextcloudBot commented Nov 18, 2022

Copy link
Copy Markdown

backport of #35218

@icewind1991@backportbot-nextcloud
delay updating setup providers untill we register the mounts
4b4b80b
otherwise the fallback to a full setup for a missing cached mount provider will lead to a race condition
Signed-off-by: Robin Appelman <robin@icewind.nl>
@backportbot-nextcloudbackportbot-nextcloudBot added this to the Nextcloud 24.0.8 milestone Nov 18, 2022
@szaimenszaimen added bug 3. to review Waiting for reviews labels Nov 18, 2022
PVince81
PVince81 approved these changes Nov 18, 2022
View reviewed changes

@PVince81PVince81 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 18, 2022
@szaimen
szaimen merged commit d9ad303 into stable24Nov 18, 2022
@szaimen
szaimen deleted the backport/35218/stable24 branch November 18, 2022 16:42
@blizzzblizzz mentioned this pull request Nov 21, 2022
Merged
9 tasks
@r-hmn

r-hmn commented Nov 29, 2022

Copy link
Copy Markdown

Question(don't know where to ask otherwise)
Will this be in the upcoming https://github.com/nextcloud/all-in-one/releases/tag/v3.1.0 ?
Otherwise share's function in AIO is still broken and thus unusable.

@szaimen

szaimen commented Nov 29, 2022

Copy link
Copy Markdown
Contributor

Question(don't know where to ask otherwise) Will this be in the upcoming https://github.com/nextcloud/all-in-one/releases/tag/v3.1.0 ? Otherwise share's function in AIO is still broken and thus unusable.

Hi, see nextcloud/all-in-one#1434 (comment)

@r-hmn

r-hmn commented Nov 29, 2022•
edited
Loading

Copy link
Copy Markdown

Hi, thanks. i did execute that and it works.
ok, good that i have confirmation of you that i can use this patch on v3.1.0 also 👍
(ps. i've upgraded my old macbook by the way, now running decent hardware ;) )

@szaimen

szaimen commented Nov 29, 2022

Copy link
Copy Markdown
Contributor

Hi, thanks. i did execute that and it works. ok, good that i have confirmation of you that i can use this patch on v3.1.0 also 👍 (ps. i've upgraded my old macbook by the way, now running decent hardware ;) )

It is unfortunately already too late for that. The fix will be included in the version after 3.1.0.

@r-hmn

r-hmn commented Nov 29, 2022

Copy link
Copy Markdown

yes, i see. no worries. at least i can patch it with the same patch

@SystemKeeperSystemKeeper mentioned this pull request Dec 2, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81PVince81PVince81 approved these changes
@szaimenszaimenszaimen approved these changes
@blizzzblizzzAwaiting requested review from blizzz
@icewind1991icewind1991Awaiting requested review from icewind1991
@skjnldsvskjnldsvAwaiting requested review from skjnldsv

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Milestone

Nextcloud 24.0.8

Development

Successfully merging this pull request may close these issues.

4 participants

@r-hmn@szaimen@PVince81@icewind1991