Uh oh!
There was an error while loading. Please reload this page.
Update cache when file size === 0 - #35353
Merged
Merged
Conversation
artonge
commented
Nov 23, 2022
CollaboratorAuthor
/backport to stable25 |
artonge
commented
Nov 23, 2022
CollaboratorAuthor
/backport to stable24 |
PVince81
commented
Nov 23, 2022
Member
great find! |
PVince81
commented
Nov 23, 2022
Member
/backport to stable23 |
PVince81
commented
Nov 23, 2022
Member
backporting further because file cache inconsistencies can be nasty with some versions of the desktop client |
PVince81
commented
Nov 23, 2022
Member
@artonge linter not happy though, maybe remove the unrelated formatting changes ? |
skjnldsv
approved these changes
Nov 23, 2022
The conditions were false when $result === 0. $results here contains the number of written bits. The correct way of checking for operation success is to check if $result === false Signed-off-by: Louis Chemineau <louis@chmn.me>
artongeforce-pushed
the
artonge/fix/cache_update_when_file_size_equal_0
branch
from
November 23, 2022 11:44
fb73ab2 to
66ba90cCompareartonge
enabled auto-merge
November 23, 2022 12:56
This was referenced Nov 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The conditions were false when
$result === 0.$resultshere contains the number of written bits.The correct way of checking for operation success is to check if
$result === falseQuestion
$resultis supposed to contain for other operation, but it is probably safe to assume that none were returning 0 for saying errorHow to test