Uh oh!
There was an error while loading. Please reload this page.
[stable23] Update cache when file size === 0 - #35369
Merged
Merged
Conversation
The conditions were false when $result === 0. $results here contains the number of written bits. The correct way of checking for operation success is to check if $result === false Signed-off-by: Louis Chemineau <louis@chmn.me>
backportbot-nextcloudBot
requested review from
CarlSchwan, PVince81, artonge, icewind1991, skjnldsv and szaimenNovember 23, 2022 15:12
szaimen
approved these changes
Nov 23, 2022
artonge
approved these changes
Nov 23, 2022
artonge
enabled auto-merge
November 23, 2022 15:42
skjnldsv
approved these changes
Nov 23, 2022
blizzz
disabled auto-merge
November 23, 2022 20:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #35353