Uh oh!
There was an error while loading. Please reload this page.
Invert header if primary is bright and background disabled - #35666
Merged
Conversation
skjnldsv
requested review from
PVince81 and szaimen
and removed request for
a teamDecember 8, 2022 08:48
skjnldsvforce-pushed
the
fix/header-bright-no-bg
branch
2 times, most recently
from
December 8, 2022 09:59
c8031d3 to
4368706Compareskjnldsv
commented
Dec 8, 2022
| // let's not define the background image | ||
| if ($backgroundDeleted) { | ||
| $variables['--color-background-plain'] = $this->themingDefaults->getColorPrimary(); | ||
| $variables['--color-background-plain'] = $this->defaultPrimaryColor; |
MemberAuthor
There was a problem hiding this comment.
This change is intentional.
We're in the admin section, we should use defaultPrimaryColor instead of primaryColor
If logged in, this var will be overruled below in the user section
Collaborator
There was a problem hiding this comment.
Could you explain their differences ?
MemberAuthor
There was a problem hiding this comment.
defaultPrimaryColor = admin defined, instance-wideprimaryColor = user, active for current session
Uh oh!
There was an error while loading. Please reload this page.
artonge
requested changes
Dec 8, 2022
Uh oh!
There was an error while loading. Please reload this page.
skjnldsvforce-pushed
the
fix/header-bright-no-bg
branch
from
December 8, 2022 14:50
6e2ee9a to
0cf7609Compareartonge
approved these changes
Dec 8, 2022
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
skjnldsvforce-pushed
the
fix/header-bright-no-bg
branch
from
December 8, 2022 16:55
0cf7609 to
1acd42eComparePytal
approved these changes
Dec 8, 2022
skjnldsv
commented
Dec 8, 2022
MemberAuthor
Failure unrelated |
4 tasks
skjnldsv
commented
Jul 6, 2023
| }) | ||
| }) | ||
| describe.only('Remove the default background with a bright color', function() { |
MemberAuthor
There was a problem hiding this comment.
Suggested change
| describe.only('Remove the default background with a bright color',function(){ | |
| describe('Remove the default background with a bright color',function(){ |
🙄
MemberAuthor
There was a problem hiding this comment.
I'll take the walk of shame 🙈
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix#35664