Skip to content

Fix background theming deletion and cypress admin theming tests - #35728

Merged
skjnldsv merged 3 commits into
masterfrom
fix/cypress
Oct 19, 2023
Merged

Fix background theming deletion and cypress admin theming tests#35728
skjnldsv merged 3 commits into
masterfrom
fix/cypress

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Dec 11, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Leftover from #35666...
Restore cypress proper testing specs... 😮‍💨

  • Also added a new test to increase coverage
  • Fixed other found issues regarding user defaults not following the instance background if removed
  • Adjusted some more testing
  • Fixed proper cleanup of admin settings when undoing an image setting

Follwup:

  • Found some issues regarding how we override the #0082c9 colour with accessibility colour #006aa3.
    Will clarify with design team afterwards

@skjnldsvskjnldsv added the 3. to review Waiting for reviews label Dec 11, 2022
@skjnldsvskjnldsv added this to the Nextcloud 26 milestone Dec 11, 2022
@skjnldsv
skjnldsv requested a review from a teamDecember 11, 2022 11:07
@skjnldsvskjnldsv self-assigned this Dec 11, 2022
@skjnldsv
skjnldsv requested review from PVince81, Pytal and artonge and removed request for a teamDecember 11, 2022 11:07
@skjnldsv

This comment was marked as resolved.

Sign in to view
@skjnldsv

This comment was marked as resolved.

Sign in to view
skjnldsv
skjnldsv commented Dec 11, 2022
View reviewed changes
Comment threadapps/theming/lib/Themes/CommonThemeTrait.php
skjnldsv
skjnldsv commented Dec 11, 2022
View reviewed changes
Comment threadapps/theming/lib/ThemingDefaults.php
github-advanced-security[bot]
github-advanced-securityAI found potential problems Dec 11, 2022
View reviewed changes
Comment threadapps/theming/lib/Themes/CommonThemeTrait.php Fixed
Comment threadapps/theming/lib/Themes/CommonThemeTrait.php Fixed
Comment threadapps/theming/lib/Themes/CommonThemeTrait.php Fixed
Comment threadapps/theming/lib/Themes/CommonThemeTrait.php Fixed
Comment threadapps/theming/lib/Themes/CommonThemeTrait.php Fixed
skjnldsv
skjnldsv commented Dec 11, 2022
View reviewed changes
Comment threadapps/theming/src/AdminTheming.vue Outdated
@skjnldsvskjnldsv changed the title Remove only cypress test selector leftoverFix background theming deletion and cypress admin theming testsDec 11, 2022
@skjnldsv
skjnldsvforce-pushed the fix/cypress branch 2 times, most recently from 89911b4 to b28d97fCompareDecember 11, 2022 18:18
@skjnldsvskjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Dec 11, 2022
@PVince81

PVince81 commented Dec 16, 2022

Copy link
Copy Markdown
Member

cypress failure ? or needs rebase / restart ?

@skjnldsv

skjnldsv commented Dec 16, 2022

Copy link
Copy Markdown
MemberAuthor

cypress failure ? or needs rebase / restart ?

Need me to find time to dive into this again 🙈
image

@blizzzblizzz mentioned this pull request Feb 1, 2023
Merged
@skjnldsvskjnldsv mentioned this pull request Feb 23, 2023
Merged
@blizzzblizzz mentioned this pull request Mar 7, 2023
Merged
@blizzzblizzz modified the milestones: Nextcloud 26, Nextcloud 27Mar 9, 2023
@szaimen

szaimen commented Apr 13, 2023

Copy link
Copy Markdown
Contributor

@skjnldsv is this still relevant?

@skjnldsv

skjnldsv commented Apr 13, 2023

Copy link
Copy Markdown
MemberAuthor

Yes we should but I don't have time for this unfortunately :/

@skjnldsvskjnldsv mentioned this pull request May 3, 2023
Merged
@skjnldsv
skjnldsvforce-pushed the fix/cypress branch 2 times, most recently from 79de33f to 7d257ebCompareJuly 6, 2023 19:44
@skjnldsvskjnldsv removed this from the Nextcloud 28 milestone Sep 2, 2023
@skjnldsv
Add additional no-background and custom colour test
d10c4c3
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
Fix background removal check
a024ee1
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
Fix background removal not applying to user default theming
4f40744
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Oct 19, 2023
@skjnldsv
skjnldsv merged commit 049804d into masterOct 19, 2023
@skjnldsv
skjnldsv deleted the fix/cypress branch October 19, 2023 12:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artongeartongeartonge approved these changes
@szaimenszaimenszaimen approved these changes
@PVince81PVince81Awaiting requested review from PVince81
@PytalPytalAwaiting requested review from Pytal

Assignees

@skjnldsvskjnldsv

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugregression

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@skjnldsv@PVince81@szaimen@artonge@github-advanced-security@blizzz