Skip to content

fix(client-login-flow): Handle missing stateToken gracefully - #36552

Merged
ChristophWurst merged 1 commit into
masterfrom
fix/client-login-flow/missing-state-token
Feb 6, 2023
Merged

fix(client-login-flow): Handle missing stateToken gracefully#36552
ChristophWurst merged 1 commit into
masterfrom
fix/client-login-flow/missing-state-token

Conversation

@ChristophWurst

@ChristophWurstChristophWurst commented Feb 6, 2023•
edited
Loading

Copy link
Copy Markdown
Member
  • Resolves: OC\\Core\\Controller\\ClientFlowLoginV2Controller::grantPage(): Argument #1 ($stateToken) must be of type string, null given

Summary

  1. Open /login/v2/grant

Master: 💥
Here: 😎

TODO

  • Fix

Checklist

@ChristophWurst
fix(client-login-flow): Handle missing stateToken gracefully
88d116b
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurstChristophWurst added this to the Nextcloud 26 milestone Feb 6, 2023
@ChristophWurstChristophWurst self-assigned this Feb 6, 2023
@ChristophWurst
ChristophWurst merged commit eca7ab3 into masterFeb 6, 2023
@ChristophWurst
ChristophWurst deleted the fix/client-login-flow/missing-state-token branch February 6, 2023 15:51
@kesselb

kesselb commented Feb 7, 2023

Copy link
Copy Markdown
Contributor

Hey 👋

I believe #36286 should fix the frontend part.

@ChristophWurst

ChristophWurst commented Feb 7, 2023

Copy link
Copy Markdown
MemberAuthor

/backport to stable25

This was referenced Feb 7, 2023
Closed
Merged
@ChristophWurst

ChristophWurst commented Feb 7, 2023

Copy link
Copy Markdown
MemberAuthor

/backport to stable25

@ChristophWurst

ChristophWurst commented Feb 7, 2023

Copy link
Copy Markdown
MemberAuthor

/backport to stable24

This was referenced Feb 7, 2023
Merged
Merged
@blizzzblizzz mentioned this pull request Feb 9, 2023
Merged
@ChristophWurstChristophWurst mentioned this pull request Feb 9, 2023
Merged
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorrjuliusknorrjuliusknorr approved these changes
@julien-ncjulien-ncAwaiting requested review from julien-nc
@hamza221hamza221Awaiting requested review from hamza221
@AntreesyAntreesyAwaiting requested review from Antreesy
@max-nextcloudmax-nextcloudAwaiting requested review from max-nextcloud
+1 more reviewer
@vitormattosvitormattosvitormattos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@ChristophWurstChristophWurst

Labels

3. to reviewWaiting for reviewsbugintegration

Projects

💌 📅 👥 Groupware team
Archived in project

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

4 participants

@ChristophWurst@kesselb@vitormattos@juliusknorr