Uh oh!
There was an error while loading. Please reload this page.
[stable24] fix(client-login-flow): Handle missing stateToken gracefully - #36586
Merged
Conversation
backportbot-nextcloudBot
requested review from
Antreesy, ChristophWurst, hamza221, julien-nc, juliusknorr, max-nextcloud and vitormattosFebruary 7, 2023 13:24
Merged
blizzz
commented
Feb 7, 2023
Member
@ChristophWurst conflicts |
ChristophWurstforce-pushed
the
backport/36552/stable24
branch
from
February 7, 2023 18:16
244f579 to
ba0fbddCompareChristophWurst
approved these changes
Feb 7, 2023
blizzz
reviewed
Feb 9, 2023
| public function apptokenRedirect(string $stateToken, string $user, string $password) { | ||
| public function apptokenRedirect(?string $stateToken, string $user, string $password) { | ||
| if ($stateToken === null) { | ||
| return $this->loginTokenForbiddenResponse(); |
blizzz
commented
Feb 9, 2023
Member
moving to 24.0.11 |
ChristophWurstforce-pushed
the
backport/36552/stable24
branch
from
February 9, 2023 13:09
ba0fbdd to
572f665CompareAntreesy
removed their request for review
February 10, 2023 08:33
MichaIng
commented
Feb 27, 2023
Member
/rebase |
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
nextcloud-commandforce-pushed
the
backport/36552/stable24
branch
from
February 27, 2023 16:10
572f665 to
2b868afComparevitormattos
approved these changes
Mar 3, 2023
MichaIng
approved these changes
Mar 3, 2023
MichaIng
enabled auto-merge
March 3, 2023 13:44
juliusknorr
disabled auto-merge
March 6, 2023 11:53
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #36552 and #36634