Skip to content

Bump @nextcloud/vue from 7.5.0 to 7.6.0 - #36739

Closed
Pytal wants to merge 2 commits into
deps/nextcloud/dialogs-4.0.1from
deps/nextcloud/vue-7.6.0
Closed

Bump @nextcloud/vue from 7.5.0 to 7.6.0#36739
Pytal wants to merge 2 commits into
deps/nextcloud/dialogs-4.0.1from
deps/nextcloud/vue-7.6.0

Conversation

@Pytal

@PytalPytal commented Feb 16, 2023

Copy link
Copy Markdown
Member

Summary

Bump @nextcloud/vue from https://github.com/nextcloud/nextcloud-vue/releases/tag/v7.5.0 to https://github.com/nextcloud/nextcloud-vue/releases/tag/v7.6.0

Requires

Checklist

@Pytal

Copy link
Copy Markdown
MemberAuthor

/backport to stable25

@Pytal

Copy link
Copy Markdown
MemberAuthor

Seems to break script load order with many OC is not defined errors, there is also an

Uncaught ReferenceError: exports is not defined
at ./node_modules/@nextcloud/dialogs/dist/index.js

error which is probably related to the recent https://github.com/nextcloud/nextcloud-dialogs/releases/tag/v4.0.0 release and may be similar to nextcloud-libraries/nextcloud-vue#3753 though resolve.fullySpecified = false here doesn't seem to fix it

Any ideas @juliushaertl?

@juliusknorr

Copy link
Copy Markdown
Member

Was fixed in nextcloud-libraries/nextcloud-dialogs#761, bumping @nextcloud/dialogs to 4.0.1 should resolve this

Base automatically changed from deps/nextcloud/password-confirmation-4.0.4 to masterFebruary 17, 2023 01:46
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Pytalforce-pushed the deps/nextcloud/vue-7.6.0 branch from 831143c to dc5b585CompareFebruary 17, 2023 02:57
@Pytal
Pytal changed the base branch from master to deps/nextcloud/dialogs-4.0.1February 17, 2023 02:58
@Pytal

Copy link
Copy Markdown
MemberAuthor

Was fixed in nextcloud/nextcloud-dialogs#761, bumping @nextcloud/dialogs to 4.0.1 should resolve this

The

Uncaught ReferenceError: exports is not defined
at ./node_modules/@nextcloud/dialogs/dist/index.js

error is resolved on top of #36757 but the OC is not defined errors still persist

@Pytal
Pytal marked this pull request as draft February 17, 2023 03:01
@Pytal
Pytalforce-pushed the deps/nextcloud/dialogs-4.0.1 branch from 56bd646 to 4082d90CompareFebruary 22, 2023 03:27
@Pytal

Copy link
Copy Markdown
MemberAuthor

Superseded by #36813

@PytalPytal closed this Feb 23, 2023
@Pytal
Pytal deleted the deps/nextcloud/vue-7.6.0 branch February 24, 2023 01:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Pytal@juliusknorr@artonge@szaimen@skjnldsv