Skip to content

Fix broken search for tags in workflow checks - #36754

Merged
nickvergessen merged 2 commits into
masterfrom
bugfix/noid/fix-broken-tag-search-in-workflow-checks
Feb 24, 2023
Merged

Fix broken search for tags in workflow checks#36754
nickvergessen merged 2 commits into
masterfrom
bugfix/noid/fix-broken-tag-search-in-workflow-checks

Conversation

@nickvergessen

@nickvergessennickvergessen commented Feb 16, 2023•
edited
Loading

Copy link
Copy Markdown
Member

After #36739 we can finally switch to the new component and that also fixes the broken search.
Same issue as in nextcloud/files_automatedtagging#683

Fixesnextcloud/files_accesscontrol#300

BeforeAfter
Bildschirmfoto vom 2023-02-24 10-26-41Bildschirmfoto vom 2023-02-24 10-25-45
Bildschirmfoto vom 2023-02-24 10-26-46Bildschirmfoto vom 2023-02-24 10-25-50

Checklist

@nickvergessennickvergessen added this to the Nextcloud 26 milestone Feb 16, 2023
@nickvergessennickvergessen self-assigned this Feb 16, 2023
@nickvergessen

nickvergessen commented Feb 16, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

/backport 5c432ff to stable25

@nickvergessennickvergessen mentioned this pull request Feb 21, 2023
Closed
@skjnldsvskjnldsv mentioned this pull request Feb 23, 2023
Merged
@nickvergessen
Fix broken search for tags in workflow checks
5c432ff
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
chore(assets): Recompile JS
1f8aeef
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
nickvergessenforce-pushed the bugfix/noid/fix-broken-tag-search-in-workflow-checks branch from c613edc to 1f8aeefCompareFebruary 24, 2023 09:26
@nickvergessen
nickvergessen requested review from a team and szaimen and removed request for a teamFebruary 24, 2023 09:28
@nickvergessen

nickvergessen commented Feb 24, 2023

Copy link
Copy Markdown
MemberAuthor

Ready for review

szaimen
szaimen approved these changes Feb 24, 2023
View reviewed changes

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@nickvergessen
nickvergessen merged commit 9650685 into masterFeb 24, 2023
@nickvergessen
nickvergessen deleted the bugfix/noid/fix-broken-tag-search-in-workflow-checks branch February 24, 2023 16:20
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Feb 24, 2023
Merged
1 task
@artongeartonge mentioned this pull request Feb 27, 2023
Merged
4 tasks
@blizzzblizzz mentioned this pull request Mar 2, 2023
Merged
@PytalPytal mentioned this pull request Mar 2, 2023
Closed
9 tasks
@PytalPytal mentioned this pull request Apr 13, 2023
Closed
9 tasks
@maximelehericymaximelehericy mentioned this pull request Aug 26, 2023
Closed
@blizzzblizzz mentioned this pull request Nov 15, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcelklehrmarcelklehrmarcelklehr approved these changes
@szaimenszaimenszaimen approved these changes
@artongeartongeAwaiting requested review from artonge
@PytalPytalAwaiting requested review from Pytal

Assignees

@nickvergessennickvergessen

Labels

3. to reviewWaiting for reviewsbugfeature: workflows

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

Collaborative tags cannot be found

3 participants

@nickvergessen@marcelklehr@szaimen