Skip to content

filelist only refreshed if directory changes - #3686

Merged
nickvergessen merged 1 commit into
masterfrom
downstream-27282
Mar 3, 2017
Merged

filelist only refreshed if directory changes#3686
nickvergessen merged 1 commit into
masterfrom
downstream-27282

Conversation

@MorrisJobke

@MorrisJobkeMorrisJobke commented Mar 3, 2017•
edited
Loading

Copy link
Copy Markdown
Member

@noveens@MorrisJobke
filelist only refreshed if directory changes
93f9db4
check introduced at another method
comment added to explain one check
comment added to explain one check
unit tests added
small fixes in unit tests
missing semicolon added
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobkeMorrisJobke added 3. to review Waiting for reviews downstream labels Mar 3, 2017
@MorrisJobkeMorrisJobke added this to the Nextcloud 12.0 milestone Mar 3, 2017
@mention-bot

mention-bot commented Mar 3, 2017

Copy link
Copy Markdown

@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @butonic, @ChristophWurst and @icewind1991 to be potential reviewers.

@MorrisJobkeMorrisJobke mentioned this pull request Mar 3, 2017
Closed
@nickvergessen
nickvergessen merged commit 29e9b1f into masterMar 3, 2017
@nickvergessen
nickvergessen deleted the downstream-27282 branch March 3, 2017 10:56
@oparozoparoz mentioned this pull request Mar 5, 2017
Closed
@ChristophWurstChristophWurst mentioned this pull request Apr 11, 2017
Closed
rullzer added a commit that referenced this pull request Apr 11, 2017
@rullzer
Do reload shared views
8c01e45
Fixes#4248
The magic introduced in #3686 caused the shared views not to be updated
properly. Thus we just overwrite the _onUrlChange method in the
sharedfilelist.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzerrullzer mentioned this pull request Apr 11, 2017
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@nickvergessennickvergessennickvergessen approved these changes
@oparozoparozAwaiting requested review from oparoz
@LukasReschkeLukasReschkeAwaiting requested review from LukasReschke
@jancborchardtjancborchardtAwaiting requested review from jancborchardt
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr
@skjnldsvskjnldsvAwaiting requested review from skjnldsv
@BugsbaneBugsbaneAwaiting requested review from Bugsbane

Assignees

No one assigned

Labels

3. to reviewWaiting for reviews

Projects

None yet

Milestone

Nextcloud 12.0

Development

Successfully merging this pull request may close these issues.

File list sometimes refreshes after closing picture or video viewer

5 participants

@MorrisJobke@mention-bot@rullzer@nickvergessen@noveens