Skip to content

Do reload shared views - #4293

Merged
MorrisJobke merged 1 commit into
masterfrom
fix_4248
Apr 11, 2017
Merged

Do reload shared views#4293
MorrisJobke merged 1 commit into
masterfrom
fix_4248

Conversation

@rullzer

@rullzerrullzer commented Apr 11, 2017

Copy link
Copy Markdown
Member

Fixes#4248

The magic introduced in #3686 caused the shared views not to be updated
properly. Thus we just overwrite the _onUrlChange method in the
sharedfilelist.

To test:

  1. Create a folder foo
  2. Share that folder
  3. Navigate to Shared with others
  4. Navigate to Shared with you
  5. Navigate to Shared with others

Before: empty
Now: not empty

@rullzer
Do reload shared views
8c01e45
Fixes#4248
The magic introduced in #3686 caused the shared views not to be updated
properly. Thus we just overwrite the _onUrlChange method in the
sharedfilelist.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzerrullzer added this to the Nextcloud 12.0 milestone Apr 11, 2017
@mention-bot

mention-bot commented Apr 11, 2017

Copy link
Copy Markdown

@rullzer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MorrisJobke, @Xenopathic and @schiessle to be potential reviewers.

@rullzerrullzer mentioned this pull request Apr 11, 2017
Closed
ChristophWurst
ChristophWurst approved these changes Apr 11, 2017
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected now

@rullzerrullzer mentioned this pull request Apr 11, 2017
Merged
MorrisJobke
MorrisJobke approved these changes Apr 11, 2017
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke
MorrisJobke merged commit 45a6e37 into masterApr 11, 2017
@MorrisJobke
MorrisJobke deleted the fix_4248 branch April 11, 2017 16:53
@icewind1991icewind1991 mentioned this pull request Apr 21, 2017
Merged
@danxuliudanxuliu mentioned this pull request Oct 21, 2018
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@LukasReschkeLukasReschkeAwaiting requested review from LukasReschke
@icewind1991icewind1991Awaiting requested review from icewind1991

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbugfeature: filesfeature: sharing

Projects

None yet

Milestone

Nextcloud 12.0

Development

Successfully merging this pull request may close these issues.

4 participants

@rullzer@mention-bot@MorrisJobke@ChristophWurst