Uh oh!
There was an error while loading. Please reload this page.
Set recommended psalm options - #37505
Merged
Merged
Conversation
provokateurin
requested review from
ChristophWurst, come-nc, miaulalala and nickvergessenMarch 31, 2023 06:32
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: jld3103 <jld3103yt@gmail.com>
provokateurinforce-pushed
the
fix/recommended-psalm-options
branch
from
March 31, 2023 07:15
b0b94e5 to
fa53c7cComparenickvergessen
approved these changes
Mar 31, 2023
ChristophWurst
approved these changes
Mar 31, 2023
provokateurin
commented
Apr 3, 2023
MemberAuthor
@nickvergessen@ChristophWurst Can I get a force-merge, please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split out from #37390
Psalm 5 tells you that you should set those options because psalm 6 will enforce them.
Checklist