Skip to content

Update to psalm 5 - #37390

Merged
provokateurin merged 1 commit into
masterfrom
update/psalm-5
May 2, 2023
Merged

Update to psalm 5#37390
provokateurin merged 1 commit into
masterfrom
update/psalm-5

Conversation

@provokateurin

@provokateurinprovokateurin commented Mar 24, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Summary

Checklist

github-advanced-security[bot]
github-advanced-securityAI found potential problems Mar 25, 2023
View reviewed changes
Comment threadapps/encryption/lib/Crypto/Crypt.php Fixed
Comment threadapps/federatedfilesharing/lib/Controller/RequestHandlerController.php Fixed
@provokateurin
provokateurinforce-pushed the update/psalm-5 branch 2 times, most recently from 0da5bdd to f752b68CompareMarch 27, 2023 10:46
github-advanced-security[bot]
github-advanced-securityAI found potential problems Mar 27, 2023
View reviewed changes
Comment threadapps/files_sharing/lib/SharedStorage.php
* @param bool $isAvailable
*/
public function setAvailability($available) {
public function setAvailability($isAvailable) {

Check notice

Code scanning / Psalm

MissingReturnType

Method OCA\Files_Sharing\SharedStorage::setAvailability does not have a return type, expecting void
Comment threadapps/user_ldap/lib/Configuration.php Fixed
Comment threadlib/private/AllConfig.php Fixed
Comment threadapps/files_trashbin/lib/Trashbin.php Fixed
Comment threadapps/user_ldap/lib/Access.php Outdated
@$this->invokeLDAPMethod('modReplace', $userDN, $password);
} catch (ConstraintViolationException $e) {
throw new HintException('Password change rejected.', \OC::$server->getL10N('user_ldap')->t('Password change rejected. Hint: ') . $e->getMessage(), (int)$e->getCode());
throw new HintException('Password change rejected.', \OC::$server->getL10N('user_ldap')->t('Password change rejected. Hint: ') . $e->getMessage(), $e->getCode());

Check notice

Code scanning / Psalm

DeprecatedMethod

The method OC\Server::getL10N has been marked as deprecated
github-advanced-security[bot]
github-advanced-securityAI found potential problems Mar 28, 2023
View reviewed changes
Comment threadlib/private/Files/Cache/HomeCache.php Fixed
Comment threadapps/files_trashbin/lib/Trashbin.php Fixed
Comment threadapps/files_trashbin/lib/Trashbin.php Fixed
Comment threadapps/files_trashbin/lib/Trashbin.php Fixed
Comment threadapps/files_trashbin/lib/Trashbin.php Fixed
Comment threadapps/federatedfilesharing/lib/FederatedShareProvider.php Fixed
Comment threadapps/federatedfilesharing/lib/FederatedShareProvider.php Fixed
Comment threadapps/files_external/lib/MountConfig.php Fixed
Comment threadapps/user_ldap/lib/Configuration.php Fixed
@provokateurin
provokateurinforce-pushed the update/psalm-5 branch 4 times, most recently from 9bc45e9 to c7ec317CompareMarch 30, 2023 05:55
github-advanced-security[bot]
github-advanced-securityAI found potential problems Mar 30, 2023
View reviewed changes
Comment threadapps/updatenotification/lib/Controller/AdminController.php
// Create a new job and store the creation date
$this->jobList->add(ResetTokenBackgroundJob::class);
$this->config->setAppValue('core', 'updater.secret.created', $this->timeFactory->getTime());
$this->config->setAppValue('core', 'updater.secret.created', (string)$this->timeFactory->getTime());

Check notice

Code scanning / Psalm

DeprecatedMethod

The method OCP\AppFramework\Utility\ITimeFactory::getTime has been marked as deprecated
@provokateurinprovokateurin mentioned this pull request Mar 30, 2023
Closed
8 tasks
@provokateurin
provokateurinforce-pushed the update/psalm-5 branch 3 times, most recently from d634595 to 0be733bCompareMarch 30, 2023 15:23
@provokateurin
provokateurin marked this pull request as ready for review March 30, 2023 15:28
This was referenced Mar 31, 2023
Merged
Closed
Merged
Merged
Closed
Merged
@provokateurin
provokateurin marked this pull request as draft April 3, 2023 06:09
@provokateurinprovokateurin mentioned this pull request Apr 3, 2023
Merged
4 tasks
This was referenced Apr 14, 2023
Closed
Closed
Merged
Closed
@provokateurin
provokateurin marked this pull request as ready for review April 25, 2023 13:49
@provokateurin

provokateurin commented Apr 25, 2023

Copy link
Copy Markdown
MemberAuthor

I already tried fixing a lot of the new found issues, but it's getting out of hand. What I did now is just ignore all the new errors so that we can finally have psalm 5.

@provokateurin

provokateurin commented Apr 25, 2023

Copy link
Copy Markdown
MemberAuthor

No idea what the failing security analysis means, the output by psalm seems to be incorrect.

@provokateurinprovokateurin mentioned this pull request Apr 25, 2023
Open
@kesselb

kesselb commented Apr 25, 2023

Copy link
Copy Markdown
Contributor

image

Haha ;) An error on line 0 is not allowed 🤣

kesselb
kesselb approved these changes Apr 25, 2023
View reviewed changes

@kesselbkesselb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@provokateurin

provokateurin commented Apr 25, 2023

Copy link
Copy Markdown
MemberAuthor

Yeah I filed an issue at vimeo/psalm#9712, I hope it gets fixed soon.

come-nc
come-nc reviewed Apr 25, 2023
View reviewed changes
Comment threadbuild/psalm-baseline.xml
@provokateurin
Use psalm 5
9fddbea
Signed-off-by: jld3103 <jld3103yt@gmail.com>
@provokateurin
provokateurin enabled auto-merge May 2, 2023 11:43
@provokateurin
provokateurin merged commit 436a088 into masterMay 2, 2023
@provokateurin
provokateurin deleted the update/psalm-5 branch May 2, 2023 12:55
@ChristophWurstChristophWurst mentioned this pull request Nov 3, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kesselbkesselbkesselb approved these changes
@come-nccome-nccome-nc approved these changes
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@miaulalalamiaulalalaAwaiting requested review from miaulalala
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@provokateurin@ChristophWurst@kesselb@github-advanced-security@come-nc