Skip to content

fix(dav): Use an icon with correct color for calendar user settings section - #37526

Merged
juliusknorr merged 1 commit into
masterfrom
use-correct-icon-for-calendar-user-settings-section
Apr 5, 2023
Merged

fix(dav): Use an icon with correct color for calendar user settings section#37526
juliusknorr merged 1 commit into
masterfrom
use-correct-icon-for-calendar-user-settings-section

Conversation

@tcitworld

@tcitworldtcitworld commented Mar 31, 2023•
edited
Loading

Copy link
Copy Markdown
Member
BeforeAfter
imageimage

Follow-up to #34746

Checklist

@tcitworldtcitworld added this to the Nextcloud 27 milestone Mar 31, 2023
@tcitworld
tcitworld requested review from a team, ChristophWurst and juliusknorrMarch 31, 2023 18:23
@tcitworldtcitworld self-assigned this Mar 31, 2023
@tcitworld
tcitworld requested review from ArtificialOwl, come-nc and icewind1991 and removed request for a teamMarch 31, 2023 18:23
@tcitworld

tcitworld commented Mar 31, 2023

Copy link
Copy Markdown
MemberAuthor

/backport to stable26

szaimen
szaimen approved these changes Mar 31, 2023
View reviewed changes

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

juliusknorr
juliusknorr reviewed Apr 3, 2023
View reviewed changes
Comment threadapps/settings/lib/Sections/Personal/Calendar.php Outdated
@tcitworld
fix(dav): Use an icon with correct color for calendar user settings s…
d87e55c
…ection
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld
tcitworldforce-pushed the use-correct-icon-for-calendar-user-settings-section branch from b415ec4 to d87e55cCompareApril 4, 2023 08:07
@ChristophWurstChristophWurst added the 4. to release Ready to be released and/or waiting for tests to finish label Apr 4, 2023
@juliusknorr

juliusknorr commented Apr 5, 2023

Copy link
Copy Markdown
Member

Failure unrelated

@juliusknorr
juliusknorr merged commit 2dc96b3 into masterApr 5, 2023
@juliusknorr
juliusknorr deleted the use-correct-icon-for-calendar-user-settings-section branch April 5, 2023 14:11
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Apr 5, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurstChristophWurstChristophWurst approved these changes
@juliusknorrjuliusknorrjuliusknorr approved these changes
@szaimenszaimenszaimen approved these changes
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@icewind1991icewind1991Awaiting requested review from icewind1991icewind1991 is a code owner automatically assigned from nextcloud/server-backend
@come-nccome-ncAwaiting requested review from come-nccome-nc is a code owner automatically assigned from nextcloud/server-backend

Assignees

@tcitworldtcitworld

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: davfeature: settings

Projects

None yet

Milestone

Nextcloud 27

Development

Successfully merging this pull request may close these issues.

4 participants

@tcitworld@juliusknorr@ChristophWurst@szaimen