Skip to content

Add Calendar settings section - #34746

Merged
juliusknorr merged 1 commit into
masterfrom
add-calendar-settings-section
Nov 13, 2022
Merged

Add Calendar settings section#34746
juliusknorr merged 1 commit into
masterfrom
add-calendar-settings-section

Conversation

@tcitworld

@tcitworldtcitworld commented Oct 22, 2022

Copy link
Copy Markdown
Member

In replacement of the removed Groupware settings section in #34626

One of my own apps used the groupware section. The calendar app itself might make use of it too. #34626 (comment)

To merge after #34626

@tcitworldtcitworld added 3. to review Waiting for reviews feature: settings feature: caldav Related to CalDAV internals labels Oct 22, 2022
@tcitworldtcitworld added this to the Nextcloud 26 milestone Oct 22, 2022
@tcitworld
tcitworld requested review from a team and ChristophWurstOctober 22, 2022 18:24
@tcitworld
tcitworldforce-pushed the add-calendar-settings-section branch 3 times, most recently from 5adbd63 to e2655d4CompareOctober 22, 2022 18:36
@tcitworldtcitworld changed the title Add Calendar settings section and adapt CalDAVSettings to use it Add Calendar settings sectionOct 22, 2022
In replacement of the removed Groupware settings section in #34626
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld
tcitworldforce-pushed the add-calendar-settings-section branch from e2655d4 to 8b13f6dCompareOctober 24, 2022 08:41
@ChristophWurstChristophWurst added the pending documentation This pull request needs an associated documentation update label Oct 24, 2022
@ChristophWurst

Copy link
Copy Markdown
Member

We can list this section in nextcloud/documentation#9249 as alternative to Availability

@tcitworld

Copy link
Copy Markdown
MemberAuthor

Should it be backported as well?

@ChristophWurst

Copy link
Copy Markdown
Member

I am not sure. Let's see how the #34626 backports go. I still consider this a breaking change as it will cause trouble for any existing app that rendered onto the groupware page.

@juliusknorr
juliusknorr merged commit 7e229aa into masterNov 13, 2022
@juliusknorr
juliusknorr deleted the add-calendar-settings-section branch November 13, 2022 16:06
@DaphneMuller

Copy link
Copy Markdown
Contributor

hello @tcitworld ,
Thank you for your work on this pull request! This ticket seems to have the tag 'missing documentation', is there any chance you could clarify what documentation is missing? Is this for admins or for app developers?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsfeature: caldavRelated to CalDAV internalsfeature: settingspending documentationThis pull request needs an associated documentation update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@tcitworld@ChristophWurst@DaphneMuller@juliusknorr