Uh oh!
There was an error while loading. Please reload this page.
Fix inherited parameter names - #37543
Merged
Merged
Conversation
Signed-off-by: jld3103 <jld3103yt@gmail.com>
ChristophWurst
approved these changes
Apr 3, 2023
| * @param bool $isAvailable | ||
| */ | ||
| public function setAvailability($available) { | ||
| public function setAvailability($isAvailable) { |
Check notice
Code scanning / Psalm
MissingReturnType
come-nc
approved these changes
Apr 3, 2023
come-nc
commented
Apr 3, 2023
Contributor
diff --git a/build/psalm-baseline.xml b/build/psalm-baseline.xml
index 8661726..fa712f3 100644
--- a/build/psalm-baseline.xml+++ b/build/psalm-baseline.xml@@ -976,10 +976,6 @@
<NullableReturnStatement occurrences="1">
<code>$this->sourceRootInfo</code>
</NullableReturnStatement>
- <ParamNameMismatch occurrences="2">- <code>$available</code>- <code>$target</code>- </ParamNameMismatch>
</file>
<file src="apps/files_sharing/lib/Updater.php">
<UndefinedMethod occurrences="1">
@@ -2091,12 +2087,7 @@
<FalsableReturnStatement occurrences="1">
<code>$data</code>
</FalsableReturnStatement>
- <MoreSpecificImplementedParamType occurrences="1">- <code>$path</code>- </MoreSpecificImplementedParamType>- <ParamNameMismatch occurrences="1">- <code>$path</code>- </ParamNameMismatch>+ <MoreSpecificImplementedParamType occurrences="1"/>
</file>
<file src="lib/private/Files/Cache/Scanner.php">
<InvalidReturnStatement occurrences="1">
@@ -2271,18 +2262,6 @@
<code>$this->fileInfo</code>
</UndefinedInterfaceMethod>
</file>
- <file src="lib/private/Files/Node/NonExistingFile.php">- <ParamNameMismatch occurrences="1">- <code>$newPath</code>- </ParamNameMismatch>- </file>- <file src="lib/private/Files/Node/NonExistingFolder.php">- <ParamNameMismatch occurrences="3">- <code>$mime</code>- <code>$newPath</code>- <code>$pattern</code>- </ParamNameMismatch>- </file>
<file src="lib/private/Files/Node/Root.php">
<ImplementedReturnTypeMismatch occurrences="1">
<code>Node</code>
@@ -2514,12 +2493,6 @@
</InvalidReturnType>
</file>
<file src="lib/private/Files/Storage/Wrapper/Quota.php">
- <InvalidReturnStatement occurrences="1">- <code>$extension === 'part'</code>- </InvalidReturnStatement>- <InvalidReturnType occurrences="1">- <code>string</code>- </InvalidReturnType>
<InvalidScalarArgument occurrences="1">
<code>$free</code>
</InvalidScalarArgument>Psalm CI confirms this helps |
provokateurin
commented
Apr 3, 2023
MemberAuthor
@come-nc Do I need to update the baseline file in this PR? |
come-nc
commented
Apr 3, 2023
Contributor
No the bot will do it in another PR. |
provokateurin
commented
Apr 3, 2023
MemberAuthor
@come-nc@ChristophWurst Can I get a force merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split out from #37390
Checklist