Skip to content

feat(system-tags): show inline in files - #37938

Merged
skjnldsv merged 1 commit into
masterfrom
feat/tags-files-inline
May 2, 2023
Merged

feat(system-tags): show inline in files #37938
skjnldsv merged 1 commit into
masterfrom
feat/tags-files-inline

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Apr 26, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Rebase after #37609 is merged

Light

localhost_8080_index php_apps_files__dir=_ fileid=2 (2)

Dark

localhost_8080_index php_apps_files__dir=_ fileid=2 (1)

@skjnldsvskjnldsv added this to the Nextcloud 27 milestone Apr 26, 2023
@skjnldsvskjnldsv self-assigned this Apr 26, 2023
@skjnldsv
skjnldsvforce-pushed the feat/tags-files-inline branch from ae58f90 to 6e26134CompareApril 26, 2023 15:26
@skjnldsv
skjnldsv changed the base branch from master to showTagsApril 26, 2023 15:26
@skjnldsv
skjnldsvforce-pushed the showTags branch 2 times, most recently from 4489b3b to eb6aba3CompareApril 26, 2023 15:28
@skjnldsv
skjnldsvforce-pushed the feat/tags-files-inline branch 4 times, most recently from 7dac009 to e7a577eCompareApril 28, 2023 08:44
@skjnldsv
skjnldsvforce-pushed the showTags branch 7 times, most recently from 0bf8013 to 20df001CompareApril 28, 2023 10:24
Base automatically changed from showTags to masterApril 28, 2023 11:37
@skjnldsv
skjnldsvforce-pushed the feat/tags-files-inline branch from e7a577e to 04f3170CompareApril 28, 2023 13:18
@skjnldsv
skjnldsv requested review from a team, Pytal, artonge, jancborchardt, nimishavijay and szaimen and removed request for a teamApril 28, 2023 13:25
@skjnldsvskjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 28, 2023
@szaimen

This comment was marked as resolved.

Sign in to view
nimishavijay
nimishavijay reviewed Apr 28, 2023
View reviewed changes

@nimishavijaynimishavijay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

choosing a really long name might overlap things in certain resolutions:

Great catch, we can ellipsise for more than ~30 characters

No other comments from my side, it looks great :)

@skjnldsv

skjnldsv commented May 2, 2023

Copy link
Copy Markdown
MemberAuthor

newly added or removed labels via the sidebar will only be shown after a reload of the files app:

It depends how much time we actually want to spend on this.
It should be fixed with the new Files to Vue, but I'm not sure I should spend more time on this

jancborchardt
jancborchardt approved these changes May 2, 2023
View reviewed changes

@jancborchardtjancborchardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! :) I'd say the ellipsizing is good to fix as @nimishavijay said, but the refresh can be handled later.

@skjnldsv
feat(system-tags): show inline in files
cab8a07
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv

skjnldsv commented May 2, 2023

Copy link
Copy Markdown
MemberAuthor

image
Done

@skjnldsv
skjnldsvforce-pushed the feat/tags-files-inline branch from 04f3170 to cab8a07CompareMay 2, 2023 08:36
@skjnldsv
skjnldsv requested a review from nimishavijayMay 2, 2023 08:36
szaimen
szaimen approved these changes May 2, 2023
View reviewed changes

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It depends how much time we actually want to spend on this.
It should be fixed with the new Files to Vue, but I'm not sure I should spend more time on this

Fine by me then

@skjnldsv
skjnldsv merged commit a889c0f into masterMay 2, 2023
@skjnldsv
skjnldsv deleted the feat/tags-files-inline branch May 2, 2023 10:07
@skjnldsvskjnldsv mentioned this pull request Jun 22, 2023
Merged
4 tasks
This was referenced Aug 16, 2023
Closed
Closed
@fechnert

fechnert commented Aug 16, 2023

Copy link
Copy Markdown

This looks awesome, thank you for adding this! I'm very happy that it kinda looks like my proposal. Awesome work!

@skjnldsv

skjnldsv commented Aug 17, 2023

Copy link
Copy Markdown
MemberAuthor

Thanks for the positive feedback @fechnert 🤗

@jancborchardt

jancborchardt commented Aug 17, 2023

Copy link
Copy Markdown
Member

@fechnert suggestions and contributions like that are always welcome! :)

@gonzalo

gonzalo commented Aug 31, 2023

Copy link
Copy Markdown
Contributor

Awesome! They way that we use tags in our organization really would thank this new feature. We're still on 26, but planning to move to 27. Is this feature enabled by default in 27.0.5? or it will be in next releases?

@jancborchardt

jancborchardt commented Aug 31, 2023

Copy link
Copy Markdown
Member

@gonzalo if tags are enabled, this is how they will be shown by default from 27 on. :)

@gonzalo

gonzalo commented Sep 1, 2023

Copy link
Copy Markdown
Contributor

Just looks awesome!!
image

@lhsazevedolhsazevedo mentioned this pull request Sep 6, 2023
Merged
3 tasks
@Glandos

Glandos commented Sep 6, 2023

Copy link
Copy Markdown
Contributor

This is really great, but I have one question before opening a new issue: is it normal that tags don't show up in a public link view? They are displayed in the list of a logged in user.

@jancborchardt

jancborchardt commented Sep 11, 2023

Copy link
Copy Markdown
Member

@Glandos at least in the current form and implementation, tags are considered information private to the instance. So they will indeed not show in the list, just like they didn’t show before in the link share view.

@GlandosGlandos mentioned this pull request Sep 11, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jancborchardtjancborchardtjancborchardt approved these changes
@szaimenszaimenszaimen approved these changes
@artongeartongeAwaiting requested review from artongeartonge is a code owner automatically assigned from nextcloud/server-frontend
@PytalPytalAwaiting requested review from PytalPytal is a code owner automatically assigned from nextcloud/server-frontend
@nimishavijaynimishavijayAwaiting requested review from nimishavijay

Assignees

@skjnldsvskjnldsv

Labels

3. to reviewWaiting for reviewsenhancementfeature: filesfeature: tags

Projects

Files to vue
Status: Done

Milestone

Nextcloud 27

Development

Successfully merging this pull request may close these issues.

7 participants

@skjnldsv@szaimen@fechnert@jancborchardt@gonzalo@Glandos@nimishavijay