Skip to content

Align collaborative tags differently - #38948

Merged
skjnldsv merged 1 commit into
masterfrom
Jerome-Herbinet-collaborative-tags-alignment-change
Jun 23, 2023
Merged

Align collaborative tags differently#38948
skjnldsv merged 1 commit into
masterfrom
Jerome-Herbinet-collaborative-tags-alignment-change

Conversation

@Jerome-Herbinet

@Jerome-HerbinetJerome-Herbinet commented Jun 22, 2023

Copy link
Copy Markdown
Member

IMO, centering makes reading difficult (a bit messy, don't you think 🤔, especially because of tags length and number differences ? )

before

What I propose

Aligned to the right (currently committed in this PR) :
after
Or aligned to the left:
2023-06-22_16-25

Checklist

@Jerome-Herbinet

Copy link
Copy Markdown
MemberAuthor

Question : why my "npm run build" re-build dist/settings-vue-settings-personal-info.js and dist/settings-vue-settings-personal-info.js.map ? Is it normal ?

@skjnldsv

Copy link
Copy Markdown
Member

It should be aligned right already.
The file name expand and push everything to the right, the justify-content: center should not apply here.
Are you on Firefox?

Ref: see screenshots from #37938

@skjnldsv

Copy link
Copy Markdown
Member

Right, something must have slept through
Can you remove the flex: 1 1 100% on the table td.filename .system-tags instead then? :)
So it doesn't take more space than necessary?

image

@skjnldsv

Copy link
Copy Markdown
Member

Question : why my "npm run build" re-build dist/settings-vue-settings-personal-info.js and dist/settings-vue-settings-personal-info.js.map ? Is it normal ?

Seems like master has a discrepancy, so you fixed it here.
You can ignore, that's alright

@Jerome-Herbinet

Copy link
Copy Markdown
MemberAuthor

It should be aligned right already. The file name expand and push everything to the right, the justify-content: center should not apply here. Are you on Firefox?

Ref: see screenshots from #37938

@skjnldsv I use FF, but a new test made this morning shows up the same problem.

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Align collaborative tags differently
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
npm run build
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Following @skjnldsv suggestion
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
@Jerome-Herbinet
Jerome-Herbinetforce-pushed the Jerome-Herbinet-collaborative-tags-alignment-change branch from d65de3e to d12fbc5CompareJune 23, 2023 09:07
@Jerome-Herbinet

Copy link
Copy Markdown
MemberAuthor

Right, something must have slept through Can you remove the flex: 1 1 100% on the table td.filename .system-tags instead then? :) So it doesn't take more space than necessary?

image

@skjnldsv your suggestion was the good one. It's all folks now ! 🙂 (+ commit squashing)

@solracsfsolracsf added this to the Nextcloud 28 milestone Jun 23, 2023
@skjnldsv

Copy link
Copy Markdown
Member

/backport to stable27

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@skjnldsv
skjnldsv merged commit ff5ed3f into masterJun 23, 2023
@skjnldsv
skjnldsv deleted the Jerome-Herbinet-collaborative-tags-alignment-change branch June 23, 2023 14:01
@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@solracsf

Copy link
Copy Markdown
Member

/backport to stable27

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsdesignDesign, UI, UX, etc.feature: filesfeature: tags

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Jerome-Herbinet@skjnldsv@solracsf@szaimen