Skip to content

fix(workflowengine): Fix multiple UI issues in workflow engine admin settings - #38170

Merged
nickvergessen merged 2 commits into
masterfrom
bugfix/38165/workflow-engine-ui
May 10, 2023
Merged

fix(workflowengine): Fix multiple UI issues in workflow engine admin settings#38170
nickvergessen merged 2 commits into
masterfrom
bugfix/38165/workflow-engine-ui

Conversation

@nickvergessen

Copy link
Copy Markdown
Member

Summary

  • Placeholder of comparison is visible glitching out of the old NcMultiselect => Migrated to NcSelect
  • X button has no title/aria label and wraps to new line
  • Add new filter option was not translated
BeforeAfter
Bildschirmfoto vom 2023-05-10 09-11-58grafik

Checklist

@nickvergessen

nickvergessen commented May 10, 2023

Copy link
Copy Markdown
MemberAuthor

/backport c20fd9f to stable26

@Antreesy

This comment was marked as resolved.

Comment threadapps/workflowengine/src/components/Check.vue Outdated
@nickvergessen

Copy link
Copy Markdown
MemberAuthor

Input height is not aligned with NcSelect

Yeah can be fixed by migrating the inputs to NcTextField but I don't feel comfortable doing that skill wise (due to the v-model, etc that's necessary).

One NcMultiSelect is left there

Will have a look

@Antreesy

Copy link
Copy Markdown
Contributor

can be fixed by migrating the inputs to NcTextField

Well, NcTextField is 44px high, which is still not enough. But I could take a look afterwards

@skjnldsvskjnldsv mentioned this pull request May 10, 2023
…settings
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
nickvergessenforce-pushed the bugfix/38165/workflow-engine-ui branch from 0ff7582 to 0983572CompareMay 10, 2023 10:03
@nickvergessen

Copy link
Copy Markdown
MemberAuthor

Fixed all the other NcMultiselect components in workflowengine

@juliusknorrjuliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 10, 2023
@nickvergessen
nickvergessen merged commit 1085598 into masterMay 10, 2023
@nickvergessen
nickvergessen deleted the bugfix/38165/workflow-engine-ui branch May 10, 2023 15:16
@szaimen

Copy link
Copy Markdown
Contributor

Thanks Joas for tackling this! As far as I can see is now only one component not migrated yet:
image

@nickvergessen

Copy link
Copy Markdown
MemberAuthor

Cool, didn't even check that. I wanted to fix 1 component, ended up fixing a tone, and only 1 is left. That's a great outcome :P

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI glitch in workflowengine admin settings

4 participants

@nickvergessen@Antreesy@szaimen@juliusknorr