Uh oh!
There was an error while loading. Please reload this page.
[stable26] fix(workflowengine): Fix multiple UI issues in workflow engine admin settings - #38189
Merged
Conversation
backportbot-nextcloudBot
requested review from
Antreesy, juliusknorr and nickvergessenMay 10, 2023 15:27
…settings Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessenforce-pushed
the
backport/38170/stable26
branch
from
May 16, 2023 12:11
6966026 to
bac0941Comparenickvergessen
marked this pull request as ready for review
May 16, 2023 12:15
nickvergessen
requested review from
a team, nfebe and susnux
and removed request for
a teamMay 16, 2023 12:15
nickvergessen
enabled auto-merge
May 16, 2023 12:28
nickvergessen
approved these changes
May 16, 2023
susnux
reviewed
May 16, 2023
| :options="operators" | ||
| class="comparator" | ||
| label="name" | ||
| track-by="operator" |
Contributor
There was a problem hiding this comment.
There is no track-by for NcSelect or vue-select.
There was a problem hiding this comment.
Yeah, right. That's an oversight in master:
https://github.com/nextcloud/server/pull/38170/files#diff-89faeece31f41549ed11dd7b8c99eb2b830f068e75ab525526f8ed49a95688cbR7
Will send a new PR to master and backport it
susnux
approved these changes
May 16, 2023
Merged
szaimen
commented
Nov 16, 2023
Contributor
/backport to stable25 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #38170