Uh oh!
There was an error while loading. Please reload this page.
Move deprecation warnings to debug - #38852
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
ChristophWurst
commented
Jun 16, 2023
Debug logs and debug mode only |
ff5cf95 to
d814369Compareszaimen
commented
Jun 16, 2023
@ChristophWurst addressed |
szaimen
commented
Jun 16, 2023
/compile / |
ShGKme
commented
Jun 16, 2023
In browsers debug log is hidden by default. If some app developers are using deprecated stuff, they will know about it only if they directly turn on the verbose log level. Is it intended? And there will be no difference between important deprecation warning messages from the libs and verbose debug logs for app/lib in terms of log levels. |
szaimen
commented
Jun 16, 2023
that is what I was wondering about as well. So my suggestion would be to show these as warnings if debug mode is enabled. WDYT? |
ShGKme
commented
Jun 19, 2023
I'd either keep |
szaimen
commented
Jun 24, 2023
please check out 6dd433a |
Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: Simon L <szaimen@e.mail.de>
6dd433a to
43bc880Compareskjnldsv
commented
Jun 24, 2023
/compile amend / |
Signed-off-by: Simon L <szaimen@e.mail.de> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
43bc880 to
95deec1Compareszaimen
commented
Jun 24, 2023
/backport to stable27 |
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
szaimen
commented
Jun 24, 2023
/backport to stable27 |
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Same as #37816 but for js